Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpk: disable tune checkers in rp start unit test #5715

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

r-vasquez
Copy link
Contributor

Cover letter

Small change to avoid running the tune checkers in the unit tests for rpk redpanda start. This will reduce unit test time by ~70%:

# From
go test ./... -count=1  11.36s user 2.66s system 18% cpu 1:17.14 total

# To
go test ./... -count=1  11.25s user 1.94s system 70% cpu 18.609 total

Why?

System check "Free memory per CPU [MB]" failed with non-fatal error "open /proc/self/cgroup: file does not exist"
System check "Transparent huge pages active" failed with non-fatal error "open /sys/kernel/mm/transparent_hugepage/enabled: file does not exist"
System check "Dir '/var/lib/redpanda/data' scheduler tuned" failed with non-fatal error "open /sys/devices/virtual/block/dm-1/uevent: file does not exist"
System check "Dir '/var/lib/redpanda/data' nomerges tuned" failed with non-fatal error "open /sys/devices/virtual/block/dm-1/uevent: file does not exist"
System check "Dir '/var/lib/redpanda/data' IRQs affinity static" failed with non-fatal error "open /sys/devices/virtual/block/dm-1/uevent: file does not exist"
System check "Dir '/var/lib/redpanda/data' IRQs affinity set" failed with non-fatal error "open /sys/devices/virtual/block/dm-1/uevent: file does not exist"
System check "Connections listen backlog size" failed with non-fatal error "open /proc/sys/net/core/somaxconn: file does not exist"
System check "Max syn backlog size" failed with non-fatal error "open /proc/sys/net/ipv4/tcp_max_syn_backlog: file does not exist"
System check "Max AIO Events" failed with non-fatal error "open /proc/sys/fs/aio-max-nr: file does not exist"
System check "Clock Source" failed with non-fatal error "open /sys/devices/system/clocksource/clocksource0/current_clocksource: file does not exist"
System check "Swappiness" failed with non-fatal error "open /proc/sys/vm/swappiness: file does not exist"

Backport Required

  • not a bug fix

UX changes

  • none

Release notes

  • none

It doesn't make much sense to run the checkers in
a memory backed filesystem (Afero.MemMapFs) during
the unit test.

Unit tests for checkers are in rpk/pkg/tuners
@r-vasquez
Copy link
Contributor Author

@r-vasquez r-vasquez merged commit 4ac7a21 into redpanda-data:dev Aug 1, 2022
@r-vasquez r-vasquez deleted the avoid-rp-check branch August 1, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants