-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloud_storage/tests: match topic name when deleting manifest #5721
cloud_storage/tests: match topic name when deleting manifest #5721
Conversation
we were deleting id_allocator manifest sometimes, causing this assertion failure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
65f3fea
to
7ffc3fa
Compare
b376a68
to
97c619a
Compare
when deleting manifest in test_missing_partition we should match topic name with the manifest path.
97c619a
to
9333fa8
Compare
topics = (TopicSpec(name='panda-topic', | ||
topic_name = 'panda-topic' | ||
topics = (TopicSpec(name=topic_name, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rather than doing this, access the name from the topicspec: self.topic
is a shortcut if there is exactly one topic, or self.topics[n].name
if you have more than one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion, I tried this on another PR to sneak in this change there, but it seems this property is only defined for RedpandaTest
in rptest.tests.redpanda_test.RedpandaTest.topic
whereas this code uses rptest.tests.topic_recovery_test.MissingPartition
inherited from rptest.tests.topic_recovery_test.BaseCase
neither of which have this property.
It might be good to define a similar property on this test case.
when deleting manifest in test_missing_partition we should match topic name with the manifest path. fixes #5711
force push: adjust assertion to happen after topic match