Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: patch rpk cluster license test #5731

Merged
merged 1 commit into from
Jul 29, 2022
Merged

test: patch rpk cluster license test #5731

merged 1 commit into from
Jul 29, 2022

Conversation

r-vasquez
Copy link
Contributor

Cover letter

Moving the license check above of
with expect_exception so we can gracefully skip
the test if we are not in CI

Backport Required

  • v22.2.x

UX changes

  • none

Release notes

  • none

@r-vasquez
test: patch rpk cluster license test
0c0502e 
Moving the license check above of
`with expect_exception` so we can gracefully skip
the test if we are not in CI
graphcareful
graphcareful approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@graphcareful graphcareful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI run

@r-vasquez
Copy link
Contributor Author

CI Failure: #5711

@r-vasquez r-vasquez merged commit e08b1f9 into redpanda-data:dev Jul 29, 2022
@r-vasquez r-vasquez deleted the patch-license-test branch August 3, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphcareful graphcareful graphcareful approved these changes

@dotnwat dotnwat Awaiting requested review from dotnwat

@NyaliaLui NyaliaLui Awaiting requested review from NyaliaLui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r-vasquez @graphcareful