Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed test_dead_group_recovery #6499

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Conversation

mmaslankaprv
Copy link
Member

@mmaslankaprv mmaslankaprv commented Sep 22, 2022

Cover letter

When describing a group in a test_dead_group_recovery recovery test we must allow for rpk to return an error and then retry.

Fixes: #5079

Backport Required

  • not a bug fix
  • issue does not exist in previous branches
  • papercut/not impactful enough to backport
  • v22.2.x
  • v22.1.x
  • v21.11.x

UX changes

Describe in plain language how this PR affects an end-user. What topic flags, configuration flags, command line flags, deprecation policies etc are added/changed.

Release notes

  • none

When describing a group in a `test_dead_group` recovery test we must
allow for RPK to return an error and then retry.

Fixes: redpanda-data#5079

Signed-off-by: Michal Maslanka <michal@redpanda.com>
@mmaslankaprv mmaslankaprv changed the title Fix 5079 Fixed test_dead_group_recovery Sep 22, 2022
@dotnwat dotnwat merged commit cc6eb5c into redpanda-data:dev Sep 22, 2022
@BenPope
Copy link
Member

BenPope commented Nov 17, 2022

/backport v22.2.x

@BenPope
Copy link
Member

BenPope commented Nov 17, 2022

@vbotbuildovich
Copy link
Collaborator

Failed to run cherry-pick command. I executed the below command:

git cherry-pick -x 47711c89521d7b8aa6169f5da4fb1acbded724d3 4c53f6d09dfb7739cb8b83775e5257ab65fa21f0

Workflow run logs.

@BenPope
Copy link
Member

BenPope commented Nov 17, 2022

OK, it's already in v22.2.x

@ztlpn
Copy link
Contributor

ztlpn commented Nov 24, 2022

OK, it's already in v22.2.x

It is not, the cherry-pick failed because it had troubles applying the commit removing @ok_to_fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DescribeGroups failed in ConsumerGroupTest.test_dead_group_recovery.static_members=True
7 participants