[v22.2.x] kafka/client/consumer: Shutdown and fetch improvements #7302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Catch more error types
* Improve log level
* Avoid ignored exceptional future
E.g.:
```
Exceptional future ignored: kafka::client::broker_error ({ node: 1 }, { error_code: broker_not_available [8] })
```
Signed-off-by: Ben Pope <ben@redpanda.com>
(cherry picked from commit e102b59)
It's possible for leave to be called multiple times, for example
if the Proxy is shut down during an existing leave request. This
results in `stop()` being alled multiple times.
Protect against that.
E.g.:
```
DEBUG 2022-11-09 19:19:52,266 [shard 0] kafka/client - Consumer: type=leader, member_id={test_client-5e42d0ce-7653-465f-9bca-6accce840bfc}, name={}: leave_group req: {group_id={pandaproxy-group-210d7de0-a565-4503-b9a3-945967d0b9ba} member_id={test_client-5e42d0ce-7653-465f-9bca-6accce840bfc} members={}}
DEBUG 2022-11-09 19:19:52,267 [shard 0] kafka/client - broker.h:68 - Dispatch to node 1: leave_group req: {group_id={pandaproxy-group-210d7de0-a565-4503-b9a3-945967d0b9ba} member_id={test_client-5e42d0ce-7653-465f-9bca-6accce840bfc} members={}}
INFO 2022-11-09 19:19:52,268 [shard 0] kafka/client - consumer.cc:128 - Consumer: type=leader, member_id={test_client-5e42d0ce-7653-465f-9bca-6accce840bfc}, name={}: stop
DEBUG 2022-11-09 19:19:52,269 [shard 0] kafka/client - client.cc:89 - exception during stop: kafka::client::broker_error ({ node: 1 }, { error_code: broker_not_available [8] })
INFO 2022-11-09 19:19:52,269 [shard 0] kafka/client - consumer.cc:128 - Consumer: type=leader, member_id={test_client-5e42d0ce-7653-465f-9bca-6accce840bfc}, name={}: stop
redpanda: /home/ben/development/src/github.com/BenPope/redpanda-clang-13/vbuild/debug/clang/rp_deps_install/include/seastar/core/abort_source.hh:109: void seastar::abort_source::do_request_abort(std::optional<std::exception_ptr>): Assertion `_subscriptions' failed.
```
Signed-off-by: Ben Pope <ben@redpanda.com>
(cherry picked from commit bbaad57)
If there is an error on the partition, it's likely that the partition leader moved. Handle this by updating metadata so that the next fetch will get the partition from the correct broker. Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 81dc303)
|
Error is cause of low disk space |
Do we restart those or ask-and-wait for devprod to address disk space? |
|
Retry didn't work |
BenPope
requested review from
a team and
ivotron
and removed request for
a team
|
CI failures:
|
piyushredpanda
approved these changes
Nov 17, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #7210
Cover letter
Improve failed heartbeat logging
Handle double-leave
It's possible for leave to be called multiple times, for example if the Proxy is shut down during an existing leave request.
Handle fetch error
Update metadata if there is a partition error so that the next fetch will work.
Backport Required
UX changes
Release notes
Improvements