Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade mocha from 7.1.1 to 9.2.2 #6790

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

secpanda
Copy link

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • src/js/package.json
    • src/js/package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 589/1000
Why? Has a fix available, CVSS 7.5
Regular Expression Denial of Service (ReDoS)
SNYK-JS-MOCHA-2863123
Yes No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: mocha The new version differs by 250 commits.

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

@github-actions github-actions bot added the area/wasm WASM Data Transforms label Oct 16, 2022
@mmedenjak mmedenjak added kind/enhance New feature or request dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code area/security labels Oct 17, 2022
@graphcareful
Copy link
Contributor

LGTM mocha is really used only for unit tests anyway

graphcareful
graphcareful previously approved these changes Oct 18, 2022
@mmedenjak
Copy link
Contributor

@graphcareful we got this in the build, and I see it's a pretty big jump from 7.1.1 to 10.1.0, what can we do about this?

sh: line 1: ./node_modules/mocha/bin/mocha: No such file or directory
  | npm ERR! code ELIFECYCLE
  | npm ERR! syscall spawn
  | npm ERR! file sh
  | npm ERR! errno ENOENT
  | npm ERR! Depedencies@0.0.1 test: ./node_modules/mocha/bin/mocha -r ts-node/register "./test/**/*.ts"
  | npm ERR! spawn ENOENT
  | npm ERR!
  | npm ERR! Failed at the Depedencies@0.0.1 test script.
  | npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
  |  
  | npm ERR! A complete log of this run can be found in:
  | npm ERR! /root/.npm/_logs/2022-10-18T09_56_28_205Z-debug.log
  | task: Failed to run task "wasm:build-js": exit status 1

@graphcareful
Copy link
Contributor

Ok after some research I found out why, seems like as of v10.0.0, Mocha requires Node.js v14.0.0 or newer. We are using v12.

@graphcareful
Copy link
Contributor

Pushed commit to bump mocha to 9.2.2

@graphcareful graphcareful self-requested a review October 18, 2022 15:26
@graphcareful graphcareful changed the title [Snyk] Security upgrade mocha from 7.1.1 to 10.1.0 [Snyk] Security upgrade mocha from 7.1.1 to 9.2.2 Oct 19, 2022
@graphcareful graphcareful merged commit 8091d0e into dev Oct 19, 2022
@graphcareful graphcareful deleted the snyk-fix-00b9c2e2e6b8f4281393b8e5f3f17df1 branch March 15, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security area/wasm WASM Data Transforms dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code kind/enhance New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants