[v22.1.x] cluster,kafka: auto-populate cluster_id and prefix it with "redpanda." #4926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and check on each tick whether it is really enabled. This achieves two things: - lightweight way to enable switching it on and off without restarting redpanda (previously the enable flag was checked once at startup) - enables using the metrics reporter as a place to initialize the cluster_id in the config, as now its try_initialize_cluster_info will always run, even if metrics reporting is disabled. (cherry picked from commit fa23508)
(cherry picked from commit 0a8d377)
...and report a dummy "redpanda.initializing" cluster ID if the cluster_id isn't set yet (it should eventually be set automatically) (cherry picked from commit 6592316)
This enables the new auto-initialization of the cluster_id to do its thing. (cherry picked from commit d5075db)
This is partly a shortcut to get the cluster_id initialized promptly, but also makes sense for metrics reports in general: when a system starts up, it makes sense to get telemetry from it right away, rather than waiting for a full tick period. (cherry picked from commit e12d1eb)
Tests that previously asserted a particular config version need updating to account for the "extra" version that now results from auto-populating cluster_id. (cherry picked from commit 992b1ed)
Previously metrics reporter was only paying attention to its url if switched on: now it runs all the time (although only sending requests if it's switched on), so we need to get this right. (cherry picked from commit eff6561)
(cherry picked from commit f79efa3)
The exact == check is only correct if there are no concurrent modifications to the cluster config. Now that we auto-set cluster_id in the background, there are such background changes, so we use a >= instead. (cherry picked from commit 94a4a9a)
mmaslankaprv
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport from pull request: #4457