Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade mocha from 9.2.2 to 10.1.0 #6834

Closed
wants to merge 1 commit into from

Conversation

snyk-bot
Copy link
Contributor

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

merge advice

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • src/js/package.json
    • src/js/package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 589/1000
Why? Has a fix available, CVSS 7.5
Regular Expression Denial of Service (ReDoS)
SNYK-JS-MOCHA-2863123
Yes No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: mocha The new version differs by 250 commits.

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

@github-actions github-actions bot added the area/wasm WASM Data Transforms label Oct 19, 2022
@mmedenjak mmedenjak added dependencies Pull requests that update a dependency file area/security kind/enhance New feature or request javascript Pull requests that update Javascript code labels Oct 19, 2022
@graphcareful
Copy link
Contributor

We can't bump Mocha any higher without updating our nodejs build which is a hassle. Also this dependency is just used for unit tests. I think its ok to avoid performing this one.

@mmedenjak mmedenjak changed the title [Snyk] Security upgrade mocha from 7.1.1 to 10.1.0 [Snyk] Security upgrade mocha from 9.2.2 to 10.1.0 Oct 20, 2022
@mmedenjak
Copy link
Contributor

Closing since this requires a nodejs upgrade (or removal, see https://github.com/redpanda-data/vtools/pull/964), which is in progress and based on the fact that library is test code only and has no practical attack vector.

@mmedenjak mmedenjak closed this Oct 20, 2022
@mmedenjak mmedenjak deleted the snyk-fix-3afa34448d4c7020a91c9a4ff7199f8b branch October 20, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security area/wasm WASM Data Transforms dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code kind/enhance New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants