fix(mui): broken <DataGrid /> sizing in <ThemedLayoutV2 />
#6144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 60193b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
/deploy finefoods-material-ui |
Passing run #11294 ↗︎
Details:
Review all test suite changes for PR #6144 ↗︎ |
|||||||||||||||
github-actions
bot
temporarily deployed
to
deploy-preview-finefoods-material-ui-6144/merge
aliemir
force-pushed
the
fix/material-ui-broken-data-grid-on-themed-layout
branch
from
327c177
to
60193b8
Compare
alicanerdurmaz
approved these changes
Jul 16, 2024
This was referenced Jul 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
Changes
Due to the changes in CSS rendering in latest Google Chrome updates,
<DataGrid />components are not properly sized when used inside<ThemedLayoutV2 />component. Theoverflow: clipproperty in the layout content is causing either miscalculations on the data grid width or causing an overflow on the container and overlapping with the sidebar.This change replaces the
overflow: clipproperty withmin-heightandmin-widthproperties to ensure the layout content is properly rendered and responsive to the content inside it.Resolves #6077
Preview for
finefoods-material-uiexample: https://deploy-preview-6144--finefoods-admin-mui.netlify.app