Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mui): broken <DataGrid /> sizing in <ThemedLayoutV2 /> #6144

Merged
merged 3 commits into from
Jul 25, 2024
Merged

fix(mui): broken <DataGrid /> sizing in <ThemedLayoutV2 /> #6144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
979f8a3
chore: add changeset
aliemir Jul 16, 2024
f7fe729
fix(mui): overflow handling in layout content
aliemir Jul 16, 2024
60193b8
ci: force deploy
aliemir Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .changeset/cold-olives-allow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
"@refinedev/mui": patch
---

fix(mui): <DataGrid /> horizontal scroll is broken in <ThemedLayoutV2 />

Due to the changes in CSS rendering in latest Google Chrome updates, `<DataGrid />` components are not properly sized when used inside `<ThemedLayoutV2 />` component. The `overflow: clip` property in the layout content is causing either miscalculations on the data grid width or causing an overflow on the container and overlapping with the sidebar.

This change replaces the `overflow: clip` property with `min-height` and `min-width` properties to ensure the layout content is properly rendered and responsive to the content inside it.

[Resolves #6077](https://github.com/refinedev/refine/issues/6077)
5 changes: 2 additions & 3 deletions packages/mui/src/components/themedLayoutV2/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,9 @@ export const ThemedLayoutV2: React.FC<RefineThemedLayoutV2Props> = ({
display: "flex",
flexDirection: "column",
flex: 1,
minHeight: "100vh",
minWidth: "1px",
minHeight: "1px",
},
{ overflow: "auto" },
{ overflow: "clip" },
]}
>
<HeaderToRender />
Expand Down
Loading