[PyROOT] Add back initializer list pythonization to CPyCppyy #16338
+11
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 13 files 13 suites 3d 4h 46m 46s ⏱️ For more details on these failures, see this check. Results for commit 66c2e0c. ♻️ This comment has been updated with latest results. |
1 task
1 task
guitargeek
force-pushed
the
initializer_list_pyz
branch
from
9c2ac30
to
66c2e0c
Compare
guitargeek
requested review from
lmoneta,
dpiparo and
vepadulano
as code owners
The patch that disables the initializer list pythonization should in principle not be necessary.
Explicitly define default constructor so cppyy doesn't attempt aggregate initialization.
guitargeek
force-pushed
the
initializer_list_pyz
branch
from
e9042c4
to
bb306cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch that disables the initializer list pythonization should in principle not be necessary.
@aaronj0, let's see which tests were actually failing because of this.