Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support detailed_message for DuplicatedMethodDefinitionError, DuplicatedInterfaceMethodDefinitionError, UnknownMethodAliasError and InvalidOverloadMethodError #1281

Merged
merged 4 commits into from
Mar 20, 2023

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Mar 19, 2023

I also added support to #detailed_message for following errors.

DuplicatedMethodDefinitionError

a.rbs:2:2...2:21: ::Foo#foo has duplicated definitions in a.rbs:3:2...3:21 (RBS::DuplicatedMethodDefinitionError)

  def foo: () -> String
  ^^^^^^^^^^^^^^^^^^^^^

DuplicatedInterfaceMethodDefinitionError

a.rbs:9:2...9:14: Duplicated method definition: ::Hello#foo (RBS::DuplicatedInterfaceMethodDefinitionError)

  include _I2
  ^^^^^^^^^^^

UnknownMethodAliasError

a.rbs:2:2...2:15: Unknown method alias name: yyy => xxx (::Error) (RBS::UnknownMethodAliasError)

  alias self.xxx self.yyy
  ^^^^^^^^^^^^^^^^^^^^^^^

InvalidOverloadMethodError

a.rbs:2:2...2:36: Invalid method overloading: ::Hello#foo (RBS::InvalidOverloadMethodError)

  def foo: (Integer) -> String | ...
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

ref: #1280
ref: #1166

Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants