Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support detailed_message for InvalidVarianceAnnotationError, RecursiveAliasDefinitionError, MixinClassError and RecursiveTypeAliasError #1285

Merged
merged 4 commits into from
Mar 22, 2023

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Mar 20, 2023

I also added support to #detailed_message for following errors.

InvalidVarianceAnnotationError

a.rbs:5:2...5:14: Type parameter variance error: X is contravariant but used as incompatible variance (RBS::InvalidVarianceAnnotationError)

    include M[X]
    ^^^^^^^^^^^^

RecursiveAliasDefinitionError

a.rbs:2:2...2:15: Recursive aliases in ::Foo: foo, bar (RBS::RecursiveAliasDefinitionError)

    alias foo bar
    ^^^^^^^^^^^^^

MixinClassError

a.rbs:4:2...4:13: Cannot include a class `::Foo` in the definition of `::Bar` (RBS::MixinClassError)

    include Foo
    ^^^^^^^^^^^

RecursiveTypeAliasError

a.rbs:2:2...2:16: Recursive type alias definition found for: foo (RBS::RecursiveTypeAliasError)

    type foo = bar
    ^^^^^^^^^^^^^^

ref: #1281
ref: #1166

Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants