prototype rb: Extract instance variables and class variables

[tk0miya]

No description provided.

[tk0miya]

This patch generates the definition of instance variables and class variables just after the method definition:

# source.rb
class Foo
  def meth
    @_meth = 1
  end

  private

  def private_meth
    @_private_meth = 2
  end
end

# generated.rbs
class Foo
  def meth: () -> untyped

  @_meth: untyped
end

It seems fine.

But in another case, it's a bit strange for me if variables are defined inside a private method.

# source.rb
class Foo
  def meth
    @_meth = 1
  end

  private

  def private_meth
    @_private_meth = 2
  end
end

# generated.rbs
class Foo
  def meth: () -> untyped

  @_meth: untyped

  private

  def private_meth: () -> untyped

  @_private_meth: untyped
end

Is this acceptable? Or, do we need to reorder the definition before generation?
Please let me know your opinion.

Thanks,

[tk0miya]

Is this acceptable? Or, do we need to reorder the definition before generation?
Please let me know your opinion.

Note: After this post, I and @soutaro talked about this topic in the ruby-jp slack. And we determined to move these variable definitions to the top of the class. So I'll update this PR this weekend.

[tk0miya]

I just update my PR to sort the member of class definitions. Now instance variables and class variables will be generated at the top of each class.

[pocke]

Would you be able to support class instance variables?

class C
  def self.foo
    @foo = 42
  end

  class << self
    def bar
      @bar = 42
    end
  end

  @baz = 42
end

In this case, @foo, @bar, and @baz should be class instance variables, but rbs prototype rb outputs them as instance variables.

[tk0miya]

Thank you for reviewing. Good point! I tried to convert instance variables into class variables. Could you check this again?

[tk0miya]

It seems CI for the nightly image failed because installing the stringio gem failed.

[tk0miya]

Updated. But, after the update, I don't have a way to promote class instance variables placed just inside the class definition:

class C
 @var = nil
end

Before the update, I used the context not having a namespace...

[pocke]

Thanks!

[pocke]

Updated. But, after the update, I don't have a way to promote class instance variables placed just inside the class definition:

I understand. I'll try fixing this problem on another PR.