Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rbs prototype] Follow up ivar/cvar feature #1361

Conversation

pocke
Copy link
Member

@pocke pocke commented Jun 26, 2023

Ref: #1343

This PR contains three changes.

  • Sort members on module definition 6229641
    • It sorts members of class, but it didn't sort members of module
  • Refactor context edfa8ac
  • Support ivar in class definition ab335ae

Copy link
Contributor

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Previously it creates a new context with `dup.tap` or calling
`Context.initial`. These methods are too loose, so we confuse how to
update the context.

This patch introduces two methods to create a new context from current
context.
@pocke pocke force-pushed the _rbs_prototype__Output_class_ivar_for_ivar_in_class_definition branch from ab335ae to 213fd56 Compare June 29, 2023 02:44
@pocke pocke added this pull request to the merge queue Jun 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 29, 2023
@pocke pocke added this pull request to the merge queue Jun 29, 2023
Merged via the queue into ruby:master with commit 985f092 Jun 29, 2023
31 checks passed
@pocke pocke deleted the _rbs_prototype__Output_class_ivar_for_ivar_in_class_definition branch June 29, 2023 08:48
@soutaro soutaro added this to the RBS 3.2 milestone Jul 18, 2023
@soutaro soutaro added the Released PRs already included in the released version label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released PRs already included in the released version
Development

Successfully merging this pull request may close these issues.

3 participants