Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load cluster token from Den instead of generating client side #1228

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

jlewitt1
Copy link
Collaborator

@jlewitt1 jlewitt1 commented Sep 3, 2024

  • generate cluster tokens in Den instead of client side. tokens are now OIDC compliant, and required for enabling telemetry
  • prevent regenerating the cluster tokens unnecessarily on the client side
  • ping new den API on clusters in order to validate the token received

Copy link

sentry-io bot commented Sep 3, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: runhouse/resources/hardware/cluster.py

Function Unhandled Issue
restart_server ValueError: Error installing runhouse on cluster node <3.145.45.24> ...
Event Count: 1
restart_server ValueError: Error installing runhouse on cluster node <34.229.108.213> ...
Event Count: 1
restart_server ValueError: Failed to restart server llama-cluster main in <modul...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

Copy link
Collaborator Author

jlewitt1 commented Sep 3, 2024

runhouse/rns/rns_client.py Outdated Show resolved Hide resolved
@jlewitt1 jlewitt1 force-pushed the update-request-headers branch 25 times, most recently from 110524e to e1600b1 Compare September 7, 2024 07:04
@jlewitt1 jlewitt1 marked this pull request as ready for review September 7, 2024 07:18
@jlewitt1 jlewitt1 force-pushed the update-request-headers branch 6 times, most recently from 6214a4e to 4f39707 Compare September 12, 2024 17:23
Copy link
Contributor

@mkandler mkandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jlewitt1 jlewitt1 merged commit 192b5d0 into main Sep 12, 2024
13 checks passed
@jlewitt1 jlewitt1 deleted the update-request-headers branch September 12, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants