-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated tokens for dev ci testing #1236
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much more clear!! Is this renaming going to break anything without changing the references to the env vars too?
actually that's a good point, would we be able to reuse the same tokens for dev/prod? otherwise we would need to branch in the test code a bit to know which env var to load |
I think we'll need different tokens for dev and production since they'll be generated by a different private/public key pair on Den dev v Dev Prod (those should definitely not be the same) |
631dd6b
to
aca5cef
Compare
aca5cef
to
33801ac
Compare
e24108e
to
610da46
Compare
4b0efdf
to
1dad056
Compare
610da46
to
f0cec14
Compare
4f39707
to
5609769
Compare
f0cec14
to
5641a70
Compare
Update env vars for the various den accounts used in testing