Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated tokens for dev ci testing #1236

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

jlewitt1
Copy link
Collaborator

@jlewitt1 jlewitt1 commented Sep 5, 2024

Update env vars for the various den accounts used in testing

Copy link
Collaborator Author

jlewitt1 commented Sep 5, 2024

Copy link
Contributor

@mkandler mkandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much more clear!! Is this renaming going to break anything without changing the references to the env vars too?

@jlewitt1
Copy link
Collaborator Author

jlewitt1 commented Sep 7, 2024

actually that's a good point, would we be able to reuse the same tokens for dev/prod? otherwise we would need to branch in the test code a bit to know which env var to load

@mkandler
Copy link
Contributor

mkandler commented Sep 7, 2024

I think we'll need different tokens for dev and production since they'll be generated by a different private/public key pair on Den dev v Dev Prod (those should definitely not be the same)

@jlewitt1 jlewitt1 force-pushed the new-token-ci-support-for-den-dev branch 2 times, most recently from 631dd6b to aca5cef Compare September 8, 2024 05:00
@jlewitt1 jlewitt1 changed the title updated tokens for den dev ci testing updated tokens for ci testing Sep 9, 2024
@jlewitt1 jlewitt1 changed the title updated tokens for ci testing updated tokens for dev ci testing Sep 9, 2024
@jlewitt1 jlewitt1 force-pushed the new-token-ci-support-for-den-dev branch from aca5cef to 33801ac Compare September 9, 2024 19:44
@jlewitt1 jlewitt1 changed the base branch from main to update-request-headers September 9, 2024 19:44
@jlewitt1 jlewitt1 force-pushed the new-token-ci-support-for-den-dev branch 6 times, most recently from e24108e to 610da46 Compare September 10, 2024 09:53
@jlewitt1 jlewitt1 force-pushed the update-request-headers branch 2 times, most recently from 4b0efdf to 1dad056 Compare September 10, 2024 11:15
@jlewitt1 jlewitt1 force-pushed the new-token-ci-support-for-den-dev branch from 610da46 to f0cec14 Compare September 10, 2024 11:15
@jlewitt1 jlewitt1 force-pushed the update-request-headers branch 3 times, most recently from 4f39707 to 5609769 Compare September 12, 2024 17:39
Base automatically changed from update-request-headers to main September 12, 2024 17:41
@jlewitt1 jlewitt1 force-pushed the new-token-ci-support-for-den-dev branch from f0cec14 to 5641a70 Compare September 12, 2024 17:50
@jlewitt1 jlewitt1 merged commit 95baa6c into main Sep 12, 2024
11 of 12 checks passed
@jlewitt1 jlewitt1 deleted the new-token-ci-support-for-den-dev branch September 12, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants