Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo bench doesn't support --no-fail-fast #4228

Closed
Mark-Simulacrum opened this issue Jun 26, 2017 · 1 comment
Closed

cargo bench doesn't support --no-fail-fast #4228

Mark-Simulacrum opened this issue Jun 26, 2017 · 1 comment
Labels
Command-bench

Comments

@Mark-Simulacrum
Copy link
Member

Benchmarks are "tests" in that they can also fail, but in some cases you don't want that. Filing this to consider adding that option to cargo bench as well.
@fa7ca7 fa7ca7 mentioned this issue Jul 4, 2017
Merged
bors added a commit that referenced this issue Jul 5, 2017
@bors
Auto merge of #4248 - dethoter:issue-4228, r=alexcrichton
cc8aa6f 
bench command supports --no-fail-fast flag.

Fix for #4228.
@kellda
Copy link
Contributor

kellda commented Jun 6, 2020

#4248 is merged, maybe this can be closed ?

@Eh2406 Eh2406 closed this as completed Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Command-bench
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexcrichton @Eh2406 @Mark-Simulacrum @kellda