Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bench command supports --no-fail-fast flag. #4248

Merged
merged 1 commit into from
Jul 5, 2017
Merged

bench command supports --no-fail-fast flag. #4248

merged 1 commit into from
Jul 5, 2017

Conversation

fa7ca7
Copy link
Contributor

@fa7ca7 fa7ca7 commented Jul 4, 2017

Fix for #4228.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton alexcrichton added the relnotes Release-note worthy label Jul 5, 2017
@alexcrichton
Copy link
Member

@bors: r+

Thanks @dethoter!

@bors
Copy link
Collaborator

bors commented Jul 5, 2017

📌 Commit 63e5c17 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Jul 5, 2017

⌛ Testing commit 63e5c17 with merge cc8aa6f...

bors added a commit that referenced this pull request Jul 5, 2017
@bors
Auto merge of #4248 - dethoter:issue-4228, r=alexcrichton
cc8aa6f 
bench command supports --no-fail-fast flag.

Fix for #4228.
@bors
Copy link
Collaborator

bors commented Jul 5, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing cc8aa6f to master...

@bors bors merged commit 63e5c17 into rust-lang:master Jul 5, 2017
This was referenced Jul 5, 2017
Closed
Closed
@fa7ca7 fa7ca7 deleted the issue-4228 branch July 10, 2017 19:38
Bak-Jin-Hyeong added a commit to Bak-Jin-Hyeong/posh-cargo that referenced this pull request Aug 23, 2017
@Bak-Jin-Hyeong
Add '--no-fail-fast' option for 'bench' command
49fb74e 
See: rust-lang/cargo#4248
@kellda kellda mentioned this pull request Jun 6, 2020
Closed
@ehuss ehuss added this to the 1.20.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
relnotes Release-note worthy
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
5 participants
@fa7ca7 @rust-highfive @alexcrichton @bors @ehuss