Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spurious JSON parsing failure on bots #33390

Closed
alexcrichton opened this issue May 3, 2016 · 7 comments · Fixed by #33688
Closed

Spurious JSON parsing failure on bots #33390

alexcrichton opened this issue May 3, 2016 · 7 comments · Fixed by #33688
Assignees
Labels
A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason)

Comments

@alexcrichton
Copy link
Member

alexcrichton commented May 3, 2016

http://buildbot.rust-lang.org/builders/auto-win-gnu-32-nopt-t/builds/4079/steps/test/logs/stdio
https://gist.github.com/alexcrichton/997dd9cae99b934f945a01082d99313b
#33376 (comment)

failures:

---- [compile-fail] compile-fail\dep-graph-struct-signature.rs stdout ----
    thread '[compile-fail] compile-fail\dep-graph-struct-signature.rs' panicked at 'failed to decode compiler output as json: `ParseError(SyntaxError(ExpectedColon, 1, 11))`', C:/bot/slave/auto-win-gnu-32-nopt-t/build/src/tools/compiletest/src\json.rs:75
note: Run with `RUST_BACKTRACE=1` for a backtrace.


failures:
    [compile-fail] compile-fail\dep-graph-struct-signature.rs

test result: FAILED. 2205 passed; 1 failed; 11 ignored; 0 measured

I've seen this a few times at this point, not really sure what's going on.

cc @nikomatsakis, @jonathandturner -- the failure message here is unfortunately hiding lots of information like what happened to the underlying process, can we try and surface that?

@sophiajt
Copy link
Contributor

sophiajt commented May 3, 2016

@alexcrichton - do you have access the output it's failing to parse as json?

@sophiajt
Copy link
Contributor

sophiajt commented May 3, 2016

I guess we could dump what we couldn't parse to stdout...

@nikomatsakis
Copy link
Contributor

Possibly #33313 ?

@nikomatsakis
Copy link
Contributor

We could certainly dump the full output, yeah.

@alexcrichton
Copy link
Member Author

That'd probably do it, yeah. In general though it seems like the diagnostic of a failed test could be greatly improved to include things like the process exit code, process stdout/stderr, etc.

@jonathandturner unfortunately there aren't these kind of logs for the tests :(

@sophiajt sophiajt self-assigned this May 3, 2016
@sophiajt
Copy link
Contributor

sophiajt commented May 3, 2016

Working on a quick fix to dump the failing input

@alexcrichton
Copy link
Member Author

Another: #33376 (comment)

(different test this time)

@alexcrichton alexcrichton added the A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) label May 5, 2016
bors added a commit that referenced this issue May 19, 2016
Fix for old school error issues, improvements to new school

This PR:
* Fixes some old school error issues, specifically #33559, #33543, #33366
* Improves wording borrowck errors with match patterns
* De-emphasize multi-line spans, so we don't color the single source character when we're trying to say "span starts here"
* Rollup of #33392 (which should help fix #33390)

r? @nikomatsakis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants