Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for old school error issues, improvements to new school #33688

Merged
merged 5 commits into from
May 19, 2016
Merged

Fix for old school error issues, improvements to new school #33688

merged 5 commits into from
May 19, 2016

Conversation

sophiajt
Copy link
Contributor

This PR:

r? @nikomatsakis

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented May 17, 2016

📌 Commit c1c1ad5 has been approved by nikomatsakis

@sanxiyn
Copy link
Member

sanxiyn commented May 18, 2016

@bors r-

This failed tidy.

@sophiajt
Copy link
Contributor Author

@bors r=nikomatsakis

@bors
Copy link
Contributor

bors commented May 18, 2016

📌 Commit b0a317d has been approved by nikomatsakis

@bors
Copy link
Contributor

bors commented May 19, 2016

⌛ Testing commit b0a317d with merge 0c5d651...

bors added a commit that referenced this pull request May 19, 2016
@bors
Auto merge of #33688 - jonathandturner:fix_old_school, r=nikomatsakis
0c5d651 
Fix for old school error issues, improvements to new school

This PR:
* Fixes some old school error issues, specifically #33559, #33543, #33366
* Improves wording borrowck errors with match patterns
* De-emphasize multi-line spans, so we don't color the single source character when we're trying to say "span starts here"
* Rollup of #33392 (which should help fix #33390)

r? @nikomatsakis
@bors
Copy link
Contributor

bors commented May 19, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-32cross-opt, auto-linux-64-cargotest, auto-linux-64-cross-armhf, auto-linux-64-cross-armsf, auto-linux-64-cross-freebsd, auto-linux-64-cross-netbsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-cross-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

@bors bors merged commit b0a317d into rust-lang:master May 19, 2016
@bors bors mentioned this pull request May 19, 2016
Merged
This was referenced May 19, 2016
Closed
Closed
@sophiajt sophiajt deleted the fix_old_school branch May 19, 2016 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spurious JSON parsing failure on bots
4 participants
@sophiajt @nikomatsakis @bors @sanxiyn