Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc regression: missing type parameters for impls of generic traits #33592

Closed
mbrubeck opened this issue May 12, 2016 · 3 comments
Closed

rustdoc regression: missing type parameters for impls of generic traits #33592

mbrubeck opened this issue May 12, 2016 · 3 comments
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@mbrubeck
Copy link
Contributor

In the list of impls for a trait with type parameters, for example:

http://doc.rust-lang.org/nightly/std/convert/trait.AsRef.html#implementors

The impls currently appear like impl<T> AsRef for [T]

They should appear like impl<T> AsRef<[T]> for [T]

This is a regression from Rust 1.9 beta to Rust 1.10 nightly.
@alexcrichton alexcrichton added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label May 12, 2016
@alexcrichton
Copy link
Member

cc @mitaa, ring any bells?

@ollie27
Copy link
Member

ollie27 commented May 12, 2016

It was caused by #32558, I'm working on a fix.

@alexcrichton
Copy link
Member

Thanks @ollie27!

@ollie27 ollie27 mentioned this issue May 12, 2016
Merged
eddyb added a commit to eddyb/rust that referenced this issue May 13, 2016
@eddyb
Rollup merge of rust-lang#33600 - ollie27:rustdoc_impl_params, r=alex…
f657a30 
…crichton

rustdoc: Fix missing type parameters on impls

They were broken by rust-lang#32558.

Fixes: rust-lang#33592
bors added a commit that referenced this issue May 15, 2016
@bors
Auto merge of #33600 - ollie27:rustdoc_impl_params, r=alexcrichton
dd0ef17 
rustdoc: Fix missing type parameters on impls

They were broken by #32558.

Fixes: #33592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mbrubeck @alexcrichton @ollie27