Avoid linking to itself in implementors section of trait page #32558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| } | ||
| write!(f, "{}{}", self.for_, WhereClause(&self.generics))?; | ||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
Since this is just duplicating the code above, can the implementations be refactored?
sanxiyn
force-pushed
the
rustdoc-self-link
branch
from
d33b64d
to
b308a8c
Compare
|
Extracted duplicated code to a function. |
|
Thanks! Can you add a test for this as well? |
|
Added a test. |
|
Ping. |
|
Gah! Sorry this slipped by. @bors: r+ rollup |
|
📌 Commit 87030f6 has been approved by |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Apr 18, 2016
…labnik Avoid linking to itself in implementors section of trait page Fix rust-lang#32474.
bors
added a commit
that referenced
this pull request
Apr 18, 2016
This was referenced May 12, 2016
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
May 13, 2016
…crichton rustdoc: Fix missing type parameters on impls They were broken by rust-lang#32558. Fixes: rust-lang#33592
This was referenced Jan 23, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 8, 2021
Restore linking to itself in implementors section of trait page Reverts rust-lang#32558 as proposed in [this Zulip discussion](https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/Trait.20implementation.20self-links/near/223773273) r? `@jyn514` cc `@camelid`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #32474.