Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: jumping to a collapsed section should expand it #52517

Closed
nrc opened this issue Jul 19, 2018 · 2 comments
Closed

rustdoc: jumping to a collapsed section should expand it #52517

nrc opened this issue Jul 19, 2018 · 2 comments
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@nrc
Copy link
Member

nrc commented Jul 19, 2018

When you are in 'collapse all' mode, if you search for and then click through to a method, then you end up in some random part of the page. It would be better if the method (or field, whatever) that you're jumping to were auto-expanded and focussed.
@nrc nrc added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jul 19, 2018
@ehuss
Copy link
Contributor

ehuss commented Jul 19, 2018

See also #48726

@GuillaumeGomez
Copy link
Member

True! I'll try to do it in not too far away in the future.

@GuillaumeGomez GuillaumeGomez mentioned this issue Jul 29, 2018
Closed
@GuillaumeGomez GuillaumeGomez mentioned this issue Aug 5, 2018
Merged
cramertj added a commit to cramertj/rust that referenced this issue Aug 8, 2018
@cramertj
Rollup merge of rust-lang#53094 - GuillaumeGomez:automatic-expand, r=nrc
556995e 
Automatically expand section if url id point to one of its component

Fixes rust-lang#52517.

r? @nrc
cramertj added a commit to cramertj/rust that referenced this issue Aug 8, 2018
@cramertj
Rollup merge of rust-lang#53094 - GuillaumeGomez:automatic-expand, r=nrc
f3d57ef 
Automatically expand section if url id point to one of its component

Fixes rust-lang#52517.

r? @nrc
cramertj added a commit to cramertj/rust that referenced this issue Aug 8, 2018
@cramertj
Rollup merge of rust-lang#53094 - GuillaumeGomez:automatic-expand, r=nrc
f852b80 
Automatically expand section if url id point to one of its component

Fixes rust-lang#52517.

r? @nrc
kennytm added a commit to kennytm/rust that referenced this issue Aug 9, 2018
@kennytm
Rollup merge of rust-lang#53094 - GuillaumeGomez:automatic-expand, r=nrc
dad5b6c 
Automatically expand section if url id point to one of its component

Fixes rust-lang#52517.

r? @nrc
@ollie27 ollie27 mentioned this issue Apr 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ehuss @nrc @GuillaumeGomez