The String::from link is broken(?).

[Songbird0]

Hi,

This anchor doesn't seem to work.

Tested on: Firefox 66.0.3 (64 bits) and Vivaldi 2.4.

[hellow554]

Where do you have that anchor from?

https://doc.rust-lang.org/std/string/struct.String.html#examples

You can create a String from a literal string with String::from:

[Songbird0]

At this line <https://doc.rust-lang.org/src/alloc/string.rs.html#74>. Le mar. 23 avr. 2019 à 17:23, Marcel Hellwig <notifications@github.com> a écrit :

…

Where do you have that anchor from? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#60200 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADGG3NDGCVU6J2WOWDUEJTDPR4SYRANCNFSM4HHY5BIQ> .

[czipperz]

Should it perhaps be pointing to https://doc.rust-lang.org/std/string/struct.String.html#impl-From%3C%26%27a%20str%3E ?

[ollie27]

This looks like the same issue as #52517 and #52774.

[ehuss]

@ollie27 I'm not sure it is related to collapsing. It looks like the fragments changed in 1.33 (it worked previously). The new fragments look like #method.from-2 with -2 or some number to the individual impl. However, it looks like this link has always been wrong. The actual impl (From<&str> for String) doesn't seem to be listed anywhere? I'm a little confused.

[ollie27]

@ehuss #method.from is still there under impl From<String> for Rc<str> on the stable docs, it's just collapsed. The number suffixes are added if there is more than one with the same name but the first never gets a suffix. impl From<&str> for String is listed as impl<'a> From<&'a str> for String.

[ehuss]

Oh, indeed! It is not uncollapsing. I thought that had all been fixed.

Regardless, the fragment for the str impl method keeps changing (in stable it is method.from-6 and in nightly it is method.from-8). If the intent is to link to the correct impl, there should probably be a more stable way to do it (not sure if intra-doc links would help here).

If is desired to just link to the impl (which doesn't seem to have problems with collapsing) it could link to impl-From%3C%26%27_%20str%3E as @czipperz said (note it is '_ in nightly, not 'a, which is another worrisome point about these links getting broken over time — unfortunately this file is ignored by the linkchecker).

[czipperz]

It seems like we should have a compile time check to ensure links aren't broken. Is this possible?

[ehuss]

@czipperz There is a linkchecker, but it is disabled for String due to #32129.

[GuillaumeGomez]

I added this issue to my "I need to fix that" list.

[GuillaumeGomez]

Fixed.