Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust fails to compile on Linux SUSE, SLES11, GCC 4.8.0 #7600

Closed
orenbenkiki opened this issue Jul 5, 2013 · 5 comments
Closed

Rust fails to compile on Linux SUSE, SLES11, GCC 4.8.0 #7600

orenbenkiki opened this issue Jul 5, 2013 · 5 comments
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows O-linux Operating system: Linux

Comments

@orenbenkiki
Copy link

Full make results are pretty large, here are the results of running make a 2nd time (following a configure in a just-cloned directory):

$ make
cfg: build triple x86_64-unknown-linux-gnu
cfg: host triples x86_64-unknown-linux-gnu
cfg: target triples x86_64-unknown-linux-gnu
cfg: host for x86_64-unknown-linux-gnu is x86_64
cfg: os for x86_64-unknown-linux-gnu is unknown-linux-gnu
cfg: using gcc
cfg: no node found, omitting docs
cfg: no llnextgen found, omitting grammar-verification
make[1]: Entering directory `/nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv'
make -C /nfs/iil/home/obenkiki/private/rust/rust-HEAD//rt/x86_64-unknown-linux-gnu/stage0/libuv -f /nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv/Makefile  \
                SRCDIR=/nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv builddir_name=
make[2]: Entering directory `/nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/rt/x86_64-unknown-linux-gnu/stage0/libuv'
gcc --std=c89 -pedantic -Wall -Wextra -Wno-unused-parameter -I/nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv/include -I/nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv/include/uv-private -I/nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv/src -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DRUST_NDEBUG -fno-omit-frame-pointer -DUSE_UTF8 -O2 -m64 -fPIC  -c /nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv/src/unix/async.c -o src/unix/async.o
In file included from /nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv/include/uv.h:67:0,
                 from /nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv/src/unix/async.c:21:
/nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv/include/uv-private/uv-unix.h:116:1: error: unknown type name ‘pthread_rwlock_t’
 typedef pthread_rwlock_t uv_rwlock_t;
 ^
/nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv/include/uv-private/uv-unix.h:140:1: error: unknown type name ‘pthread_barrier_t’
 typedef pthread_barrier_t uv_barrier_t;
 ^
In file included from /nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv/src/unix/async.c:21:0:
/nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv/include/uv.h:343:42: warning: ‘struct addrinfo’ declared inside parameter list [enabled by default]
                                   struct addrinfo* res);
                                          ^
/nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv/include/uv.h:343:42: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
make[2]: *** [src/unix/async.o] Error 1
make[2]: Leaving directory `/nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/rt/x86_64-unknown-linux-gnu/stage0/libuv'
make[1]: *** [/nfs/iil/home/obenkiki/private/rust/rust-HEAD//rt/x86_64-unknown-linux-gnu/stage0/libuv] Error 2
make[1]: Leaving directory `/nfs/iil/proj/mpgarch/computational_imaging_2/private/obenkiki/rust/rust-HEAD/src/libuv'
make: *** [rt/x86_64-unknown-linux-gnu/stage0/libuv/libuv.a] Error 2
@pnkfelix
Copy link
Member

pnkfelix commented Sep 4, 2013

visiting for triage, email from 2013-09-02.

Weird that those pthread typedefs are not available. I wonder if this is possibly fixed via a libuv update?

(Maybe an even better question: @orenbenkiki can you build libuv on its own on this platform? I.e., is the bug that we are misconfiguring our build of libuv? Or are we just inheriting a bug from libuv?)

@orenbenkiki
Copy link
Author

This seems similar to the issue people had in JuliaLang/julia#2502 (and yes, I am running an "Enterprise Linux", may god have mercy on my soul). This pointed at joyent/libuv#737 as a likely fix of the problem. I manually changed the OS variable to PLATFORM in the .mk files and it fixed the problem. It seems the rust libuv from https://github.com/brson/libuv is lagging behind the https://github.com/joyent/libuv version, so I guess the issue becomes "update rust to use a more updated version of libuv"?

@huonw
Copy link
Member

huonw commented Sep 5, 2013

A convenient coincidence: @alexcrichton opened a PR upgrading libuv (#8994) 2 hours ago.

@alexcrichton
Copy link
Member

Is this still relevant?

@orenbenkiki
Copy link
Author

Probably not, I think the library has been refreshed.

flip1995 pushed a commit to flip1995/rust that referenced this issue Sep 3, 2021
…r=camsteffen

Updated issue templates(formatting and rustbot label reference)

This PR updates our issue templates. The changes are:

1. **Make the *Meta* section smaller and not indented**

    The current format sometimes gets messed up when a user simply pasts the rustc version into the issue without indenting it to match the code block. Removing the indention should hopefully help with formatting in the future.

    <details><summary>Example of messed up formatting </summary>

    ![image](https://user-images.githubusercontent.com/17087237/130811809-2b9bc58e-c13f-4338-b34e-18648a5de413.png)

    </details>

    Additionally, I've removed the Version of Clippy from the template. Every issue that I have seen had matching rustc and Clippy versions, and just asking for `rustc -Vv` makes the issue look cleaner IMO.

2. **Add a comment explaining how additional labels can be added with ``@rustbot` label +<label>`. The explanation looks like this:**

    ```
    <!--
    Additional labels can be added to this issue by including the following command:

    `@rustbot` label +<label>

    Common labels for this issue type are:
    * `I-suggestion-causes-error`
    -->
    ```

    The example ``@rustbot`` call can sadly not be marked as code inside a comment block. But the example will not cause the bot to add any labels. See rust-lang/rust-clippy#7599

---

changelog: none

cc: `@rust-lang/clippy`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows O-linux Operating system: Linux
Projects
None yet
Development

No branches or pull requests

4 participants