Upgrade libuv to the current master (again) #8994
Conversation
|
Needs a rebase. |
|
Nothing like conflicting with yourself, should be good to go now |
|
This will likely have to rebase against rt-dns, but I'm more than willing to! |
|
Out of curiosity, what's the new stuff in libuv that this brings in? |
|
This is mostly an update to master libuv so we can continue to track on it, but @olsonjeffery was saying that file stat has improved a lot and libuv has also changed how they do error handling a fair amount. There's also a bug which fixes deadlock on process spawning, but that's not in libuv master just yet and is only present in my own fork (there's a libuv issue open about it). |
|
Do we need to rewrite all our error handling in the runtime then? |
|
Oh it's not that drastic, beforehand you had to have a |
This is a reopening of the libuv-upgrade part of rust-lang#8645. Hopefully this won't cause random segfaults all over the place. The windows regression in testing should also be fixed (it shouldn't build the whole compiler twice). A notable difference from before is that gyp is now a git submodule instead of always git-cloned at make time. This allows bundling for releases more easily. Closes rust-lang#8850
This is a reopening of the libuv-upgrade part of #8645. Hopefully this won't cause random segfaults all over the place. The windows regression in testing should also be fixed (it shouldn't build the whole compiler twice). A notable difference from before is that gyp is now a git submodule instead of always git-cloned at make time. This allows bundling for releases more easily. Closes #8850
Add lint for `unused_result_ok` This PR adds a lint to capture the use of `expr.ok();` when the result is not _really_ used. This could be interpreted as the result being checked (like it is with `unwrap()` or `expect`) but it actually only ignores the result. `let _ = expr;` expresses that intent better. This was also mentionned in rust-lang#8994 (although not being the main topic of that issue). changelog: [`misleading_use_of_ok`]: Add new lint to capture `.ok();` when the result is not _really_ used.
This is a reopening of the libuv-upgrade part of #8645. Hopefully this won't
cause random segfaults all over the place. The windows regression in testing
should also be fixed (it shouldn't build the whole compiler twice).
A notable difference from before is that gyp is now a git submodule instead of
always git-cloned at make time. This allows bundling for releases more easily.
Closes #8850