Update comment in contravariant test #12150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous definition was actually describing covariance. Fixing to describe contravariance while keeping 'static in the definition was tricky so just changed to use 'short and 'long.
bors
added a commit
that referenced
this pull request
Feb 10, 2014
The current comment actually describes *co*-variance. Fixing this to describe contravariance while keeping 'static in the definition was tricky so just changed to use 'short and 'long. I found the typo in my attempt to understand the concept of variance itself and the comment confused me. I mention this to point out that I'm new to the concept so may have still got the definition wrong, so please review with care :)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
…iny-me fix: doc url link type fix: rust-lang#12033 I did some debugging and found the cause looks like to be some doc links' `LinkType` are kept as `Shortcut` which don't make sense for url links. This PR should resolve both problems in the origin issue, but aside this PR, more work are needed for doc_links. about `LinkType`: https://github.com/raphlinus/pulldown-cmark/blob/f29bd1e228913690e5092c9594e4e607423ff0aa/src/lib.rs#L191-L210
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Aug 8, 2024
Add lint for `unused_result_ok` This PR adds a lint to capture the use of `expr.ok();` when the result is not _really_ used. This could be interpreted as the result being checked (like it is with `unwrap()` or `expect`) but it actually only ignores the result. `let _ = expr;` expresses that intent better. This was also mentionned in rust-lang#8994 (although not being the main topic of that issue). changelog: [`misleading_use_of_ok`]: Add new lint to capture `.ok();` when the result is not _really_ used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current comment actually describes co-variance.
Fixing this to describe contravariance while keeping 'static in the definition was tricky so just changed to use 'short and 'long.
I found the typo in my attempt to understand the concept of variance itself and the comment confused me. I mention this to point out that I'm new to the concept so may have still got the definition wrong, so please review with care :)