Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Notable traits shows wrong type parameter #80737

Closed
camelid opened this issue Jan 6, 2021 · 5 comments · Fixed by #91748
Closed

rustdoc: Notable traits shows wrong type parameter #80737

camelid opened this issue Jan 6, 2021 · 5 comments · Fixed by #91748
Labels
A-traits Area: Trait system C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@camelid
Copy link
Member

camelid commented Jan 6, 2021

The "Notable traits" popup for Entry::or_insert shows notable traits for &'_ mut I when it should show &'a mut V (or at least &'_ mut V):

image

Note that this happens for other functions on Entry. Another example is Entry::key which shows &'_ mut I when it should show &'a K.

I'm not 100% sure this is a bug, but the behavior is definitely confusing: I'm not sure what the notable traits popup is referring to when it references an I type parameter (mut I doesn't even appear in the file that Entry is defined in...).

@camelid camelid added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-traits Area: Trait system C-bug Category: This is a bug. labels Jan 6, 2021
@jyn514
Copy link
Member

jyn514 commented Jan 6, 2021

I think this is a duplicate of #14072.

@camelid
Copy link
Member Author

camelid commented Jan 6, 2021

Hmm, that seems possible.

Wow, that issue is so old: it refers to uint! Off-topic: is there a way to see what the docs from then look like?

@jyn514
Copy link
Member

jyn514 commented Jan 7, 2021

Off-topic: is there a way to see what the docs from then look like?

Yes, you can manually type the version number in the URL: https://doc.rust-lang.org/1.0.0/std/

@camelid
Copy link
Member Author

camelid commented Jan 7, 2021

Thanks! I forgot about that. However, I meant for the docs pre-1.0. Do you know of any way to view those?

@camelid
Copy link
Member Author

camelid commented Dec 12, 2021

Thanks! I forgot about that. However, I meant for the docs pre-1.0. Do you know of any way to view those?

Followup: 0.11.0 is the earliest version I could find docs for: https://doc.rust-lang.org/0.11.0/std/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-traits Area: Trait system C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants