rustdoc: Add regression test for Iterator as notable trait on &mut T #91748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
notriddle
force-pushed
the
notriddle/doc-notable_trait-mut_t_is_not_an_iterator
branch
from
2555b7b
to
17206cb
Compare
notriddle
changed the title
camelid
added
the
T-rustdoc
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 11, 2021
…it-mut_t_is_not_ref_t, r=Mark-Simulacrum rustdoc: Add regression test for Iterator as notable trait on &T Closes rust-lang#78160 This regression test is different from the one in rust-lang#91748, because while neither of these function should have Iterator marked as a notable trait, the reasons are different. * In this PR, it returns `&T where T: Iterator`. The `mut` is what's missing. * In rust-lang#91748, it returns `&mut T`. The trait bounds are what's missing.
|
@bors r+ rollup |
|
📌 Commit 17206cb has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 12, 2021
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#91746 (Btree: assert more API compatibility) - rust-lang#91748 (rustdoc: Add regression test for Iterator as notable trait on &mut T) - rust-lang#91811 (bootstrap: Change unwrap() to expect() for WIX path) - rust-lang#91814 (doc: fix typo in comments) - rust-lang#91815 (better span for unexpected normalization failure in CTFE engine) - rust-lang#91817 (rustbot: Add autolabeling for `T-rustdoc`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
notriddle
deleted the
notriddle/doc-notable_trait-mut_t_is_not_an_iterator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #80737