Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a stage0 stdtest build to make check #8493

Closed
brson opened this issue Aug 13, 2013 · 3 comments
Closed

Add a stage0 stdtest build to make check #8493

brson opened this issue Aug 13, 2013 · 3 comments

Comments

@brson
Copy link
Contributor

brson commented Aug 13, 2013

It would be nice to ensure that this continues to work since it makes runtime hacking easier.
@toddaaro
Copy link
Contributor

Some thoughts from my day without stage0 working on the runtime:

The main issue is that with a borked runtime you can't build the stage1 compiler, and then can't run tests as part of stage1. A joy of self-hosting.

A workaround suggested by @brson is to build the stage1 compiler with a clean repository, and then use NO_REBUILD=1 with your changes to skip compiling the compiler. The problem is that this doesn't seem to work - something about this process results in changes to struct definitions causing random segfaults. It is likely other types of changes can cause badtimes too.

So I think the conclusion is that without check-stage0-std we just can't do any runtime development, unless we go through absurd hurdles to debug using rustc as the test program. So even if it means bot cycle time goes up I think it is super important this gets checked.

@bblum
Copy link
Contributor

bblum commented Aug 14, 2013

#8470

@brson
Copy link
Contributor Author

brson commented Aug 18, 2013

Closing dupe.

@brson brson closed this as completed Aug 18, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Jun 30, 2022
@bors
Auto merge of rust-lang#9015 - kyoto7250:issue_8493, r=Jarcho
93ebd0e 
ignore item in `thread_local!` macro

close rust-lang#8493

This PR ignores `thread_local` macro in `declare_interior_mutable_const`.

changelog: ignore `thread_local!` macro in `declare_interior_mutable_const`
flip1995 pushed a commit to flip1995/rust that referenced this issue Jul 28, 2022
@bors
Auto merge of rust-lang#9246 - kyoto7250:reopen_issue_8493, r=Jarcho
a14edd5 
check macro statements in `[non_copy_const]`

close rust-lang#8493
close rust-lang#9224

This PR fixes false positives in `[non_copy_const]`.

changelog: fix false positives in`[non_copy_const]`

---

r? `@Jarcho`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brson @toddaaro @bblum