Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mingw 4.0 has broken headers #9246

Closed
vadimcn opened this issue Sep 17, 2013 · 6 comments
Closed

Mingw 4.0 has broken headers #9246

vadimcn opened this issue Sep 17, 2013 · 6 comments
Labels
O-windows Operating system: Windows

Comments

@vadimcn
Copy link
Contributor

vadimcn commented Sep 17, 2013

The latest mingw (4.0 as of this writing) has some broken headers, which break Rust build:
@klutzy
Copy link
Contributor

klutzy commented Sep 17, 2013

cc #8598

@klutzy klutzy mentioned this issue Sep 17, 2013
Closed
vadimcn added a commit to vadimcn/rust that referenced this issue Sep 17, 2013
@vadimcn
The purpose of these headers is to fix issues with mingw v4.0, as des…
c3fd430 
…cribed in rust-lang#9246.

This works by adding this directory to GCC include search path before mingw system headers directories,
so we can intercept their inclusions and add missing definitions without having to modify files in mingw/include.
@vadimcn vadimcn mentioned this issue Sep 17, 2013
Merged
bors added a commit that referenced this issue Sep 18, 2013
@bors
auto merge of #9254 : vadimcn/rust/fix-mingw-v4, r=brson
adb638f 
Fix Rust build on mingw v4.0
See #9246 for details.
@klutzy
Copy link
Contributor

klutzy commented Nov 7, 2013

FILE_FLAG_FIRST_PIPE_INSTANCE is fixed on mingw 4.0.3. Other two issues are still open.

@klutzy klutzy mentioned this issue Nov 7, 2013
Closed
@alexcrichton
Copy link
Member

Have these all been fixed in moving to mingw-w64?

@klutzy
Copy link
Contributor

klutzy commented May 6, 2014

Yep! (src/etc/mingw-fix-inlcude/ is still used, but it has no effect.)

@vadimcn
Copy link
Contributor Author

vadimcn commented May 6, 2014

Are we ready to drop support for mingw? If so, we should get rid of
mingw-fix-include.

@alexcrichton
Copy link
Member

These aren't really much of a maintenance burden right now, so I don't think we need to invest too much effort into removing them.

I also wouldn't classify this as a bug any longer, however. If issues crop up in the future, we can remove the extra header files at that time, but for now we can say that we build on mingw but don't officially support it. Official support will be provided for mingw-w64.

flip1995 pushed a commit to flip1995/rust that referenced this issue Jul 28, 2022
@bors
Auto merge of rust-lang#9246 - kyoto7250:reopen_issue_8493, r=Jarcho
a14edd5 
check macro statements in `[non_copy_const]`

close rust-lang#8493
close rust-lang#9224

This PR fixes false positives in `[non_copy_const]`.

changelog: fix false positives in`[non_copy_const]`

---

r? `@Jarcho`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-windows Operating system: Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @klutzy @vadimcn