Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix RPIT ICE for implicit HRTB when missing dyn #101468

Merged
merged 1 commit into from
Sep 7, 2022
Merged

fix RPIT ICE for implicit HRTB when missing dyn #101468

merged 1 commit into from
Sep 7, 2022

Conversation

spastorino
Copy link
Member

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 6, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 6, 2022
@spastorino
Copy link
Member Author

This fixes a beta regression. I'm beta nominating this PR, given how minimal and no risk it is.

@rustbot label +beta-nominated

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 6, 2022
@cjgillot
Copy link
Contributor

cjgillot commented Sep 6, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Sep 6, 2022

📌 Commit 3f45dc1 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2022
@JohnTitor JohnTitor mentioned this pull request Sep 6, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 7, 2022
@bors
Auto merge of rust-lang#101508 - JohnTitor:rollup-i5i2vqc, r=JohnTitor
8c41305 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#101451 (Add incremental test for changing struct name in assoc type.)
 - rust-lang#101468 (fix RPIT ICE for implicit HRTB when missing dyn)
 - rust-lang#101481 (Fix compile errors for uwp-windows-msvc targets)
 - rust-lang#101484 (Remove dead broken code from const zst handling in backends)
 - rust-lang#101486 (Add list of recognized repr attributes to the unrecognized repr error)
 - rust-lang#101488 (rustdoc: remove unused CSS `#results > table`)
 - rust-lang#101491 (rustdoc: remove outdated CSS `.sub-variant > div > .item-info`)
 - rust-lang#101497 (:arrow_up: rust-analyzer)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a12e29a into rust-lang:master Sep 7, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 7, 2022
@apiraino
Copy link
Contributor

apiraino commented Sep 8, 2022

Beta backport accepted as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 8, 2022
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 19, 2022
@pietroalbini pietroalbini mentioned this pull request Sep 19, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 19, 2022
@bors
Auto merge of rust-lang#102018 - pietroalbini:pa-1.64.0, r=pietroalbini
a55dd71 
[stable] Prepare 1.64.0 release

This PR prepares the 1.64.0 stable release builds.

In addition to bumping the channel and including the latest release notes changes, this PR also backports the following PRs:

*  rust-lang#100852
*  rust-lang#101366
*  rust-lang#101468
*  rust-lang#101922

This PR also reverts the following PRs, as decided in rust-lang#101899 (comment):

* rust-lang#95295
* rust-lang#99136 (followup to the previous PR)

r? `@ghost`
cc `@rust-lang/release`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjgillot cjgillot cjgillot left review comments

Assignees

@cjgillot cjgillot

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

ICE: generic RPIT with implicit HRTB when missing dyn
7 participants
@spastorino @cjgillot @bors @apiraino @pietroalbini @rust-highfive @rustbot