Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: remove unused CSS #results > table #101488

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

notriddle
Copy link
Contributor

@notriddle notriddle commented Sep 6, 2022

This code was added in 96ef2f8 to improve rendering of the search results table, but results have not used a table since b615c0c switched it to rendering with <div> tags.

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Sep 6, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 6, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rust-highfive
Copy link
Collaborator

r? @jsha

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 6, 2022
This code was added in 96ef2f8 to improve
rendering of the search results table, but results have not used a table
since b615c0c switched it to rendering with
`<div>` tags.
@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 6, 2022

📌 Commit 4282802 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 7, 2022
Rollup of 8 pull requests

Successful merges:

 - rust-lang#101451 (Add incremental test for changing struct name in assoc type.)
 - rust-lang#101468 (fix RPIT ICE for implicit HRTB when missing dyn)
 - rust-lang#101481 (Fix compile errors for uwp-windows-msvc targets)
 - rust-lang#101484 (Remove dead broken code from const zst handling in backends)
 - rust-lang#101486 (Add list of recognized repr attributes to the unrecognized repr error)
 - rust-lang#101488 (rustdoc: remove unused CSS `#results > table`)
 - rust-lang#101491 (rustdoc: remove outdated CSS `.sub-variant > div > .item-info`)
 - rust-lang#101497 (:arrow_up: rust-analyzer)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cf41b38 into rust-lang:master Sep 7, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 7, 2022
@notriddle notriddle deleted the notriddle/results-table branch September 7, 2022 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants