Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recover from impl Trait in type param bound #102345

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Recover from impl Trait in type param bound #102345

merged 1 commit into from
Oct 10, 2022

Conversation

chenyukang
Copy link
Member

Fixes #102182
r? @estebank

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 27, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 27, 2022
estebank
estebank approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@estebank estebank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicks

compiler/rustc_parse/src/parser/generics.rs Outdated Show resolved Hide resolved
compiler/rustc_parse/src/parser/generics.rs Outdated Show resolved Hide resolved
compiler/rustc_parse/src/parser/generics.rs Show resolved Hide resolved
@estebank
Copy link
Contributor

estebank commented Oct 9, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Oct 9, 2022

📌 Commit 7b2f04a has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2022
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 10, 2022
@JohnTitor
Rollup merge of rust-lang#102345 - chenyukang:fix-102182-impl-trait, …
c79429d 
…r=estebank

Recover from impl Trait in type param bound

Fixes rust-lang#102182
r? `@estebank`
This was referenced Oct 10, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 10, 2022
@bors
Auto merge of rust-lang#102867 - JohnTitor:rollup-qnwsajt, r=JohnTitor
e495b37 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#102275 (Stabilize `half_open_range_patterns`)
 - rust-lang#102323 (Trying to suggest additional lifetime parameter)
 - rust-lang#102345 (Recover from impl Trait in type param bound)
 - rust-lang#102845 (Elaborate trait ref to compute object safety.)
 - rust-lang#102860 (Add missing documentation for FileNameDisplayPreference variants)
 - rust-lang#102862 (From<Alignment> for usize & NonZeroUsize)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 303ebd5 into rust-lang:master Oct 10, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebank estebank estebank approved these changes

Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.

Recover from impl Trait in type param bound
5 participants
@chenyukang @estebank @bors @rust-highfive @rustbot