Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

From<Alignment> for usize & NonZeroUsize #102862

Merged
merged 1 commit into from
Oct 10, 2022
Merged

From<Alignment> for usize & NonZeroUsize #102862

merged 1 commit into from
Oct 10, 2022

Conversation

scottmcm
Copy link
Member

@scottmcm scottmcm commented Oct 9, 2022

Since you mentioned these two in #102072 (comment),
r? @thomcc

Tracking Issue: #102070

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 9, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 9, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@scottmcm scottmcm mentioned this pull request Oct 9, 2022
Open
@scottmcm scottmcm added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Oct 9, 2022
@thomcc
Copy link
Member

thomcc commented Oct 9, 2022

Looks great!

@bors r+

@bors
Copy link
Contributor

bors commented Oct 9, 2022

📌 Commit 0718aec has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2022
@JohnTitor JohnTitor mentioned this pull request Oct 10, 2022
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 10, 2022
@JohnTitor
Rollup merge of rust-lang#102862 - scottmcm:more-alignment-traits, r=…
4d5b4a8 
…thomcc

From<Alignment> for usize & NonZeroUsize

Since you mentioned these two in rust-lang#102072 (comment),
r? `@thomcc`

Tracking Issue: rust-lang#102070
@JohnTitor JohnTitor mentioned this pull request Oct 10, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 10, 2022
@bors
Auto merge of rust-lang#102867 - JohnTitor:rollup-qnwsajt, r=JohnTitor
e495b37 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#102275 (Stabilize `half_open_range_patterns`)
 - rust-lang#102323 (Trying to suggest additional lifetime parameter)
 - rust-lang#102345 (Recover from impl Trait in type param bound)
 - rust-lang#102845 (Elaborate trait ref to compute object safety.)
 - rust-lang#102860 (Add missing documentation for FileNameDisplayPreference variants)
 - rust-lang#102862 (From<Alignment> for usize & NonZeroUsize)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6d35efe into rust-lang:master Oct 10, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 10, 2022
@scottmcm scottmcm mentioned this pull request Oct 18, 2022
Open
6 tasks
@scottmcm scottmcm deleted the more-alignment-traits branch October 26, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
6 participants
@scottmcm @rustbot @rust-log-analyzer @thomcc @bors @rust-highfive