Rewrite `extern-flag-rename-transitive`. `debugger-visualizer-dep-info`, `metadata-flag-frobs-symbols`, `extern-overrides-distribution` and `forced-unwind-terminate-pof` `run-make` tests to rmake #126644

Oneirical · 2024-06-18T20:48:19Z

Part of #121876 and the associated Google Summer of Code project.

try-job: dist-x86_64-apple

rustbot · 2024-06-18T20:48:27Z

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-06-18T20:48:29Z

The run-make-support library was changed

cc @jieyouxu

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

jieyouxu · 2024-06-18T21:20:49Z

@bors delegate+ (for try job, don't r+ yet)

bors · 2024-06-18T21:20:52Z

✌️ @Oneirical, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

Oneirical · 2024-06-19T00:00:41Z

@bors try

Rewrite `extern-flag-rename-transitive`. `debugger-visualizer-dep-info`, `metadata-flag-frobs-symbols`, `extern-overrides-distribution` and `forced-unwind-terminate-pof` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Intentionally removed `only-linux`, needs MSVC tryjob. try-job: x86_64-msvc

bors · 2024-06-19T00:01:52Z

⌛ Trying commit b1433d3 with merge fd5f17e...

bors · 2024-06-19T01:50:19Z

💔 Test failed - checks-actions

jieyouxu · 2024-06-19T02:05:34Z

@bors r-

Oneirical · 2024-06-19T13:48:58Z

Did you r- by muscle memory? Hehe

So, it seems like this forced-unwind-terminate-pof test uses pthread, a POSIX exclusive. I nerfed the ignore down from only-linux to ignore-windows, as it should work on MacOS/BSD too.

Oneirical · 2024-06-19T14:47:11Z

@rustbot review

I'm quite confident about this working on OSX, but I added the try job in case you want to make sure before putting this through the full CI.

jieyouxu · 2024-06-19T14:59:56Z

Did you r- by muscle memory? Hehe

Sorry, I was doing rollups at the time and was doing r- for a couple of different PRs and saw test failed in this PR lol

jieyouxu · 2024-06-19T15:01:10Z

Yes, tests look good but let's run a try job to double check

@bors try

jieyouxu · 2024-06-19T15:02:12Z

r=me if the try job comes back green

Rewrite `extern-flag-rename-transitive`. `debugger-visualizer-dep-info`, `metadata-flag-frobs-symbols`, `extern-overrides-distribution` and `forced-unwind-terminate-pof` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). try-job: dist-x86_64-apple

bors · 2024-06-19T17:09:31Z

☀️ Try build successful - checks-actions
Build commit: a8c593c (a8c593c062e992c338e6d015c53d32d745e15dd2)

Oneirical · 2024-06-19T17:20:27Z

@bors r=@jieyouxu

bors · 2024-06-19T17:20:30Z

📌 Commit 2eab81a has been approved by jieyouxu

It is now in the queue for this repository.

jieyouxu · 2024-06-19T17:22:44Z

tests/run-make/metadata-flag-frobs-symbols/rmake.rs

+    rustc()
+        .input("bar.rs")
+        .extern_("foo1", rust_lib_name("foo-a"))
+        .extern_("foo2", rust_lib_name("foo-b"))
+        .print("link-args")
+        .run();


Question: is this supposed to be checking output of --print=link-args? I know the original test does the same thing.

You mean, if it should be run_unchecked? I don't see why, if the original test worked on all platforms as run, why would we need to reduce the exactitude of the test by not checking?

No I mean that this invocation uses --print=link-args but we're not checking what stdout contains (or what the content of --print=link-args is), is that intentional?

That is quite weird indeed, my guess is that the test writer left it in as a way to debug their own test if it failed. The test works locally without it, so I am removing it now.

Thanks, r=me when CI passes

jieyouxu · 2024-06-19T17:23:05Z

@bors r- (sorry i just noticed this)

Oneirical · 2024-06-19T19:52:13Z

@bors r=@jieyouxu

bors · 2024-06-19T19:52:15Z

📌 Commit e7ea063 has been approved by jieyouxu

It is now in the queue for this repository.

Rewrite `extern-flag-rename-transitive`. `debugger-visualizer-dep-info`, `metadata-flag-frobs-symbols`, `extern-overrides-distribution` and `forced-unwind-terminate-pof` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). try-job: dist-x86_64-apple

Rollup of 7 pull requests Successful merges: - rust-lang#124807 (Migrate `run-make/rustdoc-io-error` to `rmake.rs`) - rust-lang#126095 (Migrate `link-args-order`, `ls-metadata` and `lto-readonly-lib` `run-make` tests to `rmake`) - rust-lang#126308 (Ban `ArrayToPointer` and `MutToConstPointer` from runtime MIR) - rust-lang#126620 (Actually taint InferCtxt when a fulfillment error is emitted) - rust-lang#126629 (Migrate `run-make/compressed-debuginfo` to `rmake.rs`) - rust-lang#126644 (Rewrite `extern-flag-rename-transitive`. `debugger-visualizer-dep-info`, `metadata-flag-frobs-symbols`, `extern-overrides-distribution` and `forced-unwind-terminate-pof` `run-make` tests to rmake) - rust-lang#126650 (Rename a bunch of things in the new solver and `rustc_type_ir`) r? `@ghost` `@rustbot` modify labels: rollup

Rewrite `extern-flag-rename-transitive`. `debugger-visualizer-dep-info`, `metadata-flag-frobs-symbols`, `extern-overrides-distribution` and `forced-unwind-terminate-pof` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). try-job: dist-x86_64-apple

Rollup of 9 pull requests Successful merges: - rust-lang#126095 (Migrate `link-args-order`, `ls-metadata` and `lto-readonly-lib` `run-make` tests to `rmake`) - rust-lang#126534 (Migrate `run-make/comment-section` to `rmake.rs`) - rust-lang#126620 (Actually taint InferCtxt when a fulfillment error is emitted) - rust-lang#126629 (Migrate `run-make/compressed-debuginfo` to `rmake.rs`) - rust-lang#126644 (Rewrite `extern-flag-rename-transitive`. `debugger-visualizer-dep-info`, `metadata-flag-frobs-symbols`, `extern-overrides-distribution` and `forced-unwind-terminate-pof` `run-make` tests to rmake) - rust-lang#126650 (Rename a bunch of things in the new solver and `rustc_type_ir`) - rust-lang#126698 (Migrate `unknown-mod-stdin`, `issue-68794-textrel-on-minimal-lib`, `raw-dylib-cross-compilation` and `used-cdylib-macos` `run-make` tests to rmake) - rust-lang#126703 (reword the hint::blackbox non-guarantees) - rust-lang#126708 (Minimize `can_begin_literal_maybe_minus` usage) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#126095 (Migrate `link-args-order`, `ls-metadata` and `lto-readonly-lib` `run-make` tests to `rmake`) - rust-lang#126629 (Migrate `run-make/compressed-debuginfo` to `rmake.rs`) - rust-lang#126644 (Rewrite `extern-flag-rename-transitive`. `debugger-visualizer-dep-info`, `metadata-flag-frobs-symbols`, `extern-overrides-distribution` and `forced-unwind-terminate-pof` `run-make` tests to rmake) - rust-lang#126735 (collect attrs in const block expr) - rust-lang#126737 (Remove `feature(const_closures)` from libcore) - rust-lang#126740 (add `needs-unwind` to UI test) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#126644 - Oneirical:testla-coil, r=jieyouxu Rewrite `extern-flag-rename-transitive`. `debugger-visualizer-dep-info`, `metadata-flag-frobs-symbols`, `extern-overrides-distribution` and `forced-unwind-terminate-pof` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). try-job: dist-x86_64-apple

Oneirical added 4 commits June 18, 2024 15:59

rewrite extern-flag-rename-transitive to rmake

060a13e

rewrite debugger-visualizer-dep-info to rmake

9e2ace8

rewrite metadata-flag-frobs-symbols to rmake

dff354e

rewrite extern-overrides-distribution to rmake

d1e8c6b

rustbot assigned jieyouxu Jun 18, 2024

jieyouxu mentioned this pull request Jun 18, 2024

Tracking Issue for porting run-make tests to use Rust #121876

Open

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2024

This comment has been minimized.

Sign in to view

Oneirical force-pushed the testla-coil branch from b1433d3 to 2eab81a Compare June 19, 2024 13:47

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 19, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2024

jieyouxu reviewed Jun 19, 2024

View reviewed changes

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 19, 2024

rewrite forced-unwind-terminate-pof to rmake

e7ea063

Oneirical force-pushed the testla-coil branch from 2eab81a to e7ea063 Compare June 19, 2024 18:39

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 19, 2024

jieyouxu mentioned this pull request Jun 19, 2024

Rollup of 7 pull requests #126710

Closed

jieyouxu mentioned this pull request Jun 19, 2024

Rollup of 9 pull requests #126714

Closed

jieyouxu mentioned this pull request Jun 19, 2024

Rollup of 9 pull requests #126716

Closed

matthiaskrgr mentioned this pull request Jun 20, 2024

Rollup of 6 pull requests #126745

Merged

bors merged commit bbf94b2 into rust-lang:master Jun 20, 2024
6 checks passed

rustbot added this to the 1.81.0 milestone Jun 20, 2024

Oneirical deleted the testla-coil branch June 21, 2024 00:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rewrite `extern-flag-rename-transitive`. `debugger-visualizer-dep-info`, `metadata-flag-frobs-symbols`, `extern-overrides-distribution` and `forced-unwind-terminate-pof` `run-make` tests to rmake #126644

Rewrite `extern-flag-rename-transitive`. `debugger-visualizer-dep-info`, `metadata-flag-frobs-symbols`, `extern-overrides-distribution` and `forced-unwind-terminate-pof` `run-make` tests to rmake #126644

Oneirical commented Jun 18, 2024 •

edited

Loading

rustbot commented Jun 18, 2024

rustbot commented Jun 18, 2024

jieyouxu commented Jun 18, 2024

bors commented Jun 18, 2024

Oneirical commented Jun 19, 2024

bors commented Jun 19, 2024

bors commented Jun 19, 2024

This comment has been minimized.

jieyouxu commented Jun 19, 2024

Oneirical commented Jun 19, 2024

Oneirical commented Jun 19, 2024 •

edited

Loading

jieyouxu commented Jun 19, 2024

jieyouxu commented Jun 19, 2024

jieyouxu commented Jun 19, 2024

bors commented Jun 19, 2024

Oneirical commented Jun 19, 2024

bors commented Jun 19, 2024

jieyouxu Jun 19, 2024 •

edited

Loading

Oneirical Jun 19, 2024

jieyouxu Jun 19, 2024

Oneirical Jun 19, 2024

jieyouxu Jun 19, 2024

jieyouxu commented Jun 19, 2024

Oneirical commented Jun 19, 2024

bors commented Jun 19, 2024

Rewrite extern-flag-rename-transitive. debugger-visualizer-dep-info, metadata-flag-frobs-symbols, extern-overrides-distribution and forced-unwind-terminate-pof run-make tests to rmake #126644

Rewrite extern-flag-rename-transitive. debugger-visualizer-dep-info, metadata-flag-frobs-symbols, extern-overrides-distribution and forced-unwind-terminate-pof run-make tests to rmake #126644

Conversation

Oneirical commented Jun 18, 2024 • edited Loading

rustbot commented Jun 18, 2024

rustbot commented Jun 18, 2024

jieyouxu commented Jun 18, 2024

bors commented Jun 18, 2024

Oneirical commented Jun 19, 2024

bors commented Jun 19, 2024

bors commented Jun 19, 2024

This comment has been minimized.

jieyouxu commented Jun 19, 2024

Oneirical commented Jun 19, 2024

Oneirical commented Jun 19, 2024 • edited Loading

jieyouxu commented Jun 19, 2024

jieyouxu commented Jun 19, 2024

jieyouxu commented Jun 19, 2024

bors commented Jun 19, 2024

Oneirical commented Jun 19, 2024

bors commented Jun 19, 2024

jieyouxu Jun 19, 2024 • edited Loading

Choose a reason for hiding this comment

Oneirical Jun 19, 2024

Choose a reason for hiding this comment

jieyouxu Jun 19, 2024

Choose a reason for hiding this comment

Oneirical Jun 19, 2024

Choose a reason for hiding this comment

jieyouxu Jun 19, 2024

Choose a reason for hiding this comment

jieyouxu commented Jun 19, 2024

Oneirical commented Jun 19, 2024

bors commented Jun 19, 2024

Rewrite `extern-flag-rename-transitive`. `debugger-visualizer-dep-info`, `metadata-flag-frobs-symbols`, `extern-overrides-distribution` and `forced-unwind-terminate-pof` `run-make` tests to rmake #126644

Rewrite `extern-flag-rename-transitive`. `debugger-visualizer-dep-info`, `metadata-flag-frobs-symbols`, `extern-overrides-distribution` and `forced-unwind-terminate-pof` `run-make` tests to rmake #126644

Oneirical commented Jun 18, 2024 •

edited

Loading

Oneirical commented Jun 19, 2024 •

edited

Loading

jieyouxu Jun 19, 2024 •

edited

Loading