Rollup of 6 pull requests #126745
Merged
Rollup of 6 pull requests #126745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `tail-expr-lock-poisoning` UI test uses the `panic::catch_unwind` API so it relies on unwinding being implemented. this test ought not to run on targets that do not support unwinding. add the `needs-unwind` attribute to signal this
…youxu Migrate `link-args-order`, `ls-metadata` and `lto-readonly-lib` `run-make` tests to `rmake` Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Guaranteed to fail CI until rust-lang#125736 gets merged. Will require addition of `fs_wrapper::set_permissions` in the associated module. try-job: x86_64-msvc
…mpressed-debuginfo, r=jieyouxu Migrate `run-make/compressed-debuginfo` to `rmake.rs` Part of rust-lang#121876. r? ````@jieyouxu````
Rewrite `extern-flag-rename-transitive`. `debugger-visualizer-dep-info`, `metadata-flag-frobs-symbols`, `extern-overrides-distribution` and `forced-unwind-terminate-pof` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). try-job: dist-x86_64-apple
collect attrs in const block expr Fixes rust-lang#126516 Fixes rust-lang#126647 It was forgotten to collect these attributes in the const block expression. r? `@petrochenkov`
…s, r=compiler-errors Remove `feature(const_closures)` from libcore This is an incomplete feature and apparently it has no uses in `core`. Incomplete features should generally not be used in our standard library.
… r=lcnr add `needs-unwind` to UI test the `tail-expr-lock-poisoning` UI test uses the `panic::catch_unwind` API so it relies on unwinding being implemented. this test ought not to run on targets that do not support unwinding. add the `needs-unwind` attribute to signal this
rustbot
added
A-run-make
|
@bors r+ rollup=never p=6 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: cb8a7ea0ed In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (4333551): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 691.131s -> 691.081s (-0.01%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
link-args-order,ls-metadataandlto-readonly-librun-maketests tormake#126095 (Migratelink-args-order,ls-metadataandlto-readonly-librun-maketests tormake)run-make/compressed-debuginfotormake.rs#126629 (Migraterun-make/compressed-debuginfotormake.rs)extern-flag-rename-transitive.debugger-visualizer-dep-info,metadata-flag-frobs-symbols,extern-overrides-distributionandforced-unwind-terminate-pofrun-maketests to rmake #126644 (Rewriteextern-flag-rename-transitive.debugger-visualizer-dep-info,metadata-flag-frobs-symbols,extern-overrides-distributionandforced-unwind-terminate-pofrun-maketests to rmake)feature(const_closures)from libcore #126737 (Removefeature(const_closures)from libcore)needs-unwindto UI test #126740 (addneeds-unwindto UI test)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup