Rollup of 4 pull requests #127851
Merged
Rollup of 4 pull requests #127851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These need to get their safety story straight
This previously failed on Windows because the `llvm_config` file was open as read-only.
…tgross35 Make more Windows functions `#![deny(unsafe_op_in_unsafe_fn)]` As part of rust-lang#127747, I've evaluated some more Windows functions and added `unsafe` blocks where necessary. Some are just trivial wrappers that "inherit" the full unsafety of their function, but for others I've added some safety comments. A few functions weren't actually unsafe at all. I think they were just using `unsafe fn` to avoid an `unsafe {}` block. I'm not touching `c.rs` yet because that is partially being addressed by another PR and also I have plans to further reduce the number of wrapper functions we have in there. r? libs
Prevent double reference in generic futex In the Windows futex implementation we were a little lax at allowing references to references (i.e. `&&`) which can lead to deadlocks due to reading the wrong memory address. This uses a trait to tighten the constraints and ensure this doesn't happen. r? libs
Reviewer on vacation ``@jhpratt`` asked to be set as on vacation
…onur-ozkan bootstrap: open `llvm-config` as r+w This previously failed on Windows and prevented building on Windows for compiler stuff because the `llvm-config` file was open as read-only. Tested locally on a Windows machine. Fixes rust-lang#127849.
rustbot
added
A-meta
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 17, 2024
Rollup of 4 pull requests Successful merges: - rust-lang#127763 (Make more Windows functions `#![deny(unsafe_op_in_unsafe_fn)]`) - rust-lang#127813 (Prevent double reference in generic futex) - rust-lang#127847 (Reviewer on vacation) - rust-lang#127850 (bootstrap: open `llvm-config` as r+w) r? `@ghost` `@rustbot` modify labels: rollup
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry I'm not sure what happened to the apple builder, it just kinda stopped part way through? |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 3de0a7c716 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Jul 17, 2024
Merged
|
Finished benchmarking commit (08cdc2f): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 768.642s -> 769.855s (0.16%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
#![deny(unsafe_op_in_unsafe_fn)]#127763 (Make more Windows functions#![deny(unsafe_op_in_unsafe_fn)])llvm-configas r+w #127850 (bootstrap: openllvm-configas r+w)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup