Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #127851

Merged
merged 14 commits into from
Jul 17, 2024
Merged

Rollup of 4 pull requests #127851

merged 14 commits into from
Jul 17, 2024

Commits on Jul 15, 2024

  1. Configuration menu
    Copy the full SHA
    d1a3c1d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    37295e6 View commit details
    Browse the repository at this point in the history
  3. allow(unsafe_op_in_unsafe_fn) on some functions

    These need to get their safety story straight
    ChrisDenton committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    5922234 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Remove slice_to_end

    ChrisDenton committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    55c84e3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    10b845c View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Configuration menu
    Copy the full SHA
    a33abbb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2043de1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0585c4a View commit details
    Browse the repository at this point in the history
  4. jhpratt on vacation

    ChrisDenton committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    a216a34 View commit details
    Browse the repository at this point in the history
  5. bootstrap: open llvm_config as r+w

    This previously failed on Windows because the `llvm_config` file was
    open as read-only.
    jieyouxu committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    3bee507 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#127763 - ChrisDenton:safe-unsafe-unsafe, r=…

    …tgross35
    
    Make more Windows functions `#![deny(unsafe_op_in_unsafe_fn)]`
    
    As part of rust-lang#127747, I've evaluated some more Windows functions and added `unsafe` blocks where necessary. Some are just trivial wrappers that "inherit" the full unsafety of their function, but for others I've added some safety comments. A few functions weren't actually unsafe at all. I think they were just using `unsafe fn` to avoid an `unsafe {}` block.
    
    I'm not touching `c.rs` yet because that is partially being addressed by another PR and also I have plans to further reduce the number of wrapper functions we have in there.
    
    r? libs
    tgross35 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    56f9555 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#127813 - ChrisDenton:win-futex, r=joboet

    Prevent double reference in generic futex
    
    In the Windows futex implementation we were a little lax at allowing references to references (i.e. `&&`) which can lead to deadlocks due to reading the wrong memory address. This uses a trait to tighten the constraints and ensure this doesn't happen.
    
    r? libs
    tgross35 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    599d324 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#127847 - ChrisDenton:vacation, r=jhpratt

    Reviewer on vacation
    
    ``@jhpratt`` asked to be set as on vacation
    tgross35 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    5d7466e View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#127850 - jieyouxu:bootstrap-llvm-config, r=…

    …onur-ozkan
    
    bootstrap: open `llvm-config` as r+w
    
    This previously failed on Windows and prevented building on Windows for compiler stuff because the `llvm-config` file was open as read-only.
    
    Tested locally on a Windows machine.
    
    Fixes rust-lang#127849.
    tgross35 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    f99f61b View commit details
    Browse the repository at this point in the history