Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #130109

Closed
wants to merge 22 commits into from

Commits on Aug 26, 2024

  1. Add a run-make test for checking that certain rustc_ crates build o…

    …n stable
    Kobzol authored and lqd committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    893413d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7957140 View commit details
    Browse the repository at this point in the history
  3. run test in tmp dir and emit artifacts there

    otherwise the test would build in the source root's `target` folder
    lqd committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    d9794a9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2190c28 View commit details
    Browse the repository at this point in the history
  5. separate the crates to test from the test setup

    it'll be easier to see and update the list: the other cmd args
    can just be ignored
    lqd committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    0577035 View commit details
    Browse the repository at this point in the history
  6. remove unneeded type ascription

    lqd committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    f1df0c5 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. address review comments

    lqd committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    a178559 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Configuration menu
    Copy the full SHA
    7dd1be1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f6d2cfc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ae661dd View commit details
    Browse the repository at this point in the history
  4. Make download-ci-llvm = true check if CI llvm is available

    and make it the default for the compiler profile, as to prevent
    unnecessarily checking out `src/llvm-project` with `"if-unchanged"`.
    Urgau committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    5f367bb View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. Rename variant AddrOfRegion of RegionVariableOrigin to `BorrowReg…

    …ion`
    
    because "Borrow" is the more idiomatic Rust term than "AddrOf".
    gurry committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    c0b0627 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f7d4da6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cfe85a3 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2024

  1. Configuration menu
    Copy the full SHA
    ec11001 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#129473 - Urgau:fix-llvm-if-unchanged, r=onu…

    …r-ozkan
    
    use  `download-ci-llvm=true` in the default compiler config
    
    rust-lang@1ca2708 made it so that the `src/llvm-project` submodule has to be checkout for `download-ci-llvm = "if-unchanged"` to know if the submodule has been changed, but that is not required, if the submodule hasn't been checkout it cannot have been modified.
    
    ~~This PR restore the previous behavior by only updating the submodule if it has already been checkout.~~
    
    This PR makes `download-ci-llvm = true` check if CI llvm is available and make it the default for the compiler profile, as to prevent unnecessarily checking out `src/llvm-project` with `"if-unchanged"`.
    
    r? ``@onur-ozkan``
    matthiaskrgr committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    548d1b9 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#129529 - lqd:stable-new-solver, r=Kobzol

    Add test to build crates used by r-a on stable
    
    r? ````@Kobzol````
    
    I've opened other PRs for this one to work and they've landed already. I cherry-picked your commit, and added the last remaining pieces we needed I think.
    matthiaskrgr committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    381ac10 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#130025 - Urgau:missing_docs-expect, r=petro…

    …chenkov
    
    Also emit `missing_docs` lint with `--test` to fulfil expectations
    
    This PR removes the "test harness" suppression of the `missing_docs` lint to be able to fulfil `#[expect]` (expectations) as it is now "relevant".
    
    I think the goal was to maybe avoid false-positive while linting on public items under `#[cfg(test)]` but with effective visibility we should no longer have any false-positive.
    
    Another possibility would be to query the lint level and only emit the lint if it's of expect level, but that is even more hacky.
    
    Fixes rust-lang#130021
    matthiaskrgr committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    5e39f04 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#130048 - nebulark:runmake_llvm_pdbutil, r=j…

    …ieyouxu
    
    run-make-support: Add llvm-pdbutil
    
    Add llvm-pdbutil to run-make-support, so we can write better unit tests for PDB specific features.
    
    r? `@jieyouxu`
    `@rustbot` label: +O-windows
    matthiaskrgr committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    16dadb8 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#130070 - gurry:rename-regionkind-addof-to-r…

    …ef, r=compiler-errors
    
    Rename variant `AddrOfRegion` of `RegionVariableOrigin` to `BorrowRegion`
    
    because "Borrow" is the more idiomatic Rust term than "AddrOf".
    matthiaskrgr committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    0d0c4dd View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#130087 - RalfJung:option-const-iter, r=work…

    …ingjubilee
    
    remove 'const' from 'Option::iter'
    
    This is kind of pointless to be a `const fn` since you can't do anything with the iterator. It is also the only `const fn iter*` in the entire standard library. It probably got constified when `~const` traits got added everywhere, and then was forgotten to be de-constified when that was undone.
    
    The rest of the const_option feature seems like it can reasonably be stabilized, but this one IMO should not be stabilized, and it's not worth creating a new tracking issue.
    
    Cc rust-lang#67441
    matthiaskrgr committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    07778a1 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#130092 - zslayton:master, r=jieyouxu

    Fixes typo in wasm32-wasip2 doc comment
    matthiaskrgr committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    d4e2ba4 View commit details
    Browse the repository at this point in the history