Require indices to be uint #13257
Merged
Require indices to be uint #13257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit tightens up the restriction on types used to index slices to require exactly `uint` indices. Previously any integral type was accepted, but this leads to a few subtle problems: * 64-bit indices don't make much sense on 32-bit systems * Signed indices for slices used as negative indexing isn't implemented This was discussed at the recent work week, and also has some discussion on issue rust-lang#10453. Closes rust-lang#10453
bors
added a commit
that referenced
this pull request
Apr 2, 2014
The details are outlined in the first commit. Closes #10453
notriddle
pushed a commit
to notriddle/rust
that referenced
this pull request
Sep 20, 2022
…erent-methods, r=lnicola fix: Fix a crash introduced in rust-lang#13147 Reverts rust-lang/rust-analyzer#13147 https://github.com/rust-lang/rust-analyzer/actions/runs/3041499441/jobs/4898678721#step:18:62
matthiaskrgr
pushed a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 11, 2022
…ykril Ensure at least one trait bound in `TyKind::DynTy` One would expect `TyKind::DynTy` to have at least one trait bound, but we may produce a dyn type with no trait bounds at all. This patch prevents it by returning `TyKind::Error` in such cases. An "empty" dyn type would have caused panic during method resolution without rust-lang#13257. Although already fixed, I think an invariant to never produce such types would help prevent similar problems in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The details are outlined in the first commit.
Closes #10453