Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require indices to be uint #13257

Merged
merged 2 commits into from
Apr 3, 2014
Merged

Require indices to be uint #13257

merged 2 commits into from
Apr 3, 2014

Commits on Apr 2, 2014

  1. rustc: Require that vector indices are uints 

    This commit tightens up the restriction on types used to index slices to require
exactly `uint` indices. Previously any integral type was accepted, but this
leads to a few subtle problems:

  * 64-bit indices don't make much sense on 32-bit systems
  * Signed indices for slices used as negative indexing isn't implemented

This was discussed at the recent work week, and also has some discussion on
issue rust-lang#10453.

Closes rust-lang#10453
    @alexcrichton
    alexcrichton committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    46abacf View commit details
    Browse the repository at this point in the history

  2. Fix fallout of requiring uint indices

    @alexcrichton
    alexcrichton committed Apr 2, 2014
    5 Configuration menu
    Copy the full SHA
    9a259f4 View commit details
    Browse the repository at this point in the history