Add error explanations for E0374, E0375, E0376 on issue #32777 #33415
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
dfockler
changed the title
| @@ -3284,6 +3284,82 @@ impl Baz for Bar { } // Note: This is OK | |||
| ``` | |||
| "##, | |||
|
|
|||
| E0374: r##" | |||
| The trait `CoerceUnsized` may only be implemented for a coercion between | |||
There was a problem hiding this comment.
This introduction is confusing. A lot of repetitions make the whole harder than necessary to understand.
There was a problem hiding this comment.
@GuillaumeGomez Oh sorry. Just a note, I was thinking that you were supposed to put the actual error text before the error description.
|
Thanks for your work! Globally, your explanations aren't clear enough. Also, if possible, add examples that show how to fix the error (with code annotation to make it even better). |
|
cc #32777 |
|
@GuillaumeGomez Thanks for the feedback! I'll read through that RFC more closely and get some changes up soon. |
|
Thanks! Don't forget to ping me once done (github doesn't notify when PR is updated). |
|
(I don't really have anything to add to the review at this point. I'll wait to see how @dfockler responds to @GuillaumeGomez 's feedback before r+'ing this.) |
|
@GuillaumeGomez I rewrote these to comply with the rfc. If these are good let me know if I should squash them or not, Thanks. |
| @@ -3284,6 +3284,167 @@ impl Baz for Bar { } // Note: This is OK | |||
| ``` | |||
| "##, | |||
|
|
|||
| E0374: r##" | |||
| The struct you are trying to implement `CoerceUnsized` for doesn't have | |||
There was a problem hiding this comment.
This still isn't a neutral wording.
At the end, we'll ask you to squash your commits if you haven't already done it. But meantime, it's entirely up to you. A few nits to fix and I think we'll be good. |
|
@GuillaumeGomez Ok, those issues are fixed. |
|
Travis says: /home/travis/build/rust-lang/rust/src/librustc_typeck/diagnostics.rs:3289: trailing whitespace
/home/travis/build/rust-lang/rust/src/librustc_typeck/diagnostics.rs:3291: trailing whitespace
/home/travis/build/rust-lang/rust/src/librustc_typeck/diagnostics.rs:3346: trailing whitespace
/home/travis/build/rust-lang/rust/src/librustc_typeck/diagnostics.rs:3350: trailing whitespace
/home/travis/build/rust-lang/rust/src/librustc_typeck/diagnostics.rs:3351: trailing whitespace
/home/travis/build/rust-lang/rust/src/librustc_typeck/diagnostics.rs:3392: trailing whitespace
/home/travis/build/rust-lang/rust/src/librustc_typeck/diagnostics.rs:3403: trailing whitespace
/home/travis/build/rust-lang/rust/src/librustc_typeck/diagnostics.rs:3405: trailing whitespace
/home/travis/build/rust-lang/rust/src/librustc_typeck/diagnostics.rs:3406: trailing whitespace
/home/travis/build/rust-lang/rust/src/librustc_typeck/diagnostics.rs:3436: trailing whitespaceTo check such lints, run "make tidy". |
|
@GuillaumeGomez Ok, whitespace fixed. |
|
@GuillaumeGomez I squashed the commits and it passed on the last check. |
|
Great, thanks! |
|
@bors: r+ rollup |
|
📌 Commit 1e901de has been approved by |
Add error explanations for E0374, E0375, E0376 on issue rust-lang#32777
Add error explanations for E0374, E0375, E0376 on issue rust-lang#32777
No description provided.