Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: to_string not needed since we gots coercion #33603

Merged
merged 1 commit into from
May 16, 2016
Merged

doc: to_string not needed since we gots coercion #33603

merged 1 commit into from
May 16, 2016

Conversation

tshepang
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

ollie27
ollie27 reviewed May 12, 2016
View reviewed changes
src/libcollections/fmt.rs
/// ```
///
/// Please note that using [`format!`][format!] might be preferrable.
/// Example:
///
/// ```
/// let s = format!("Hello, {}!", "world");
/// assert_eq!(s, "Hello, world!".to_string());
/// assert_eq!(s, "Hello, world!";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now missing a bracket.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@apasel422
Copy link
Contributor

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented May 13, 2016

📌 Commit 226cb9c has been approved by apasel422

sanxiyn added a commit to sanxiyn/rust that referenced this pull request May 14, 2016
@sanxiyn
Rollup merge of rust-lang#33603 - tshepang:no-need, r=apasel422
344b02b 
doc: to_string not needed since we gots coercion
@sanxiyn sanxiyn mentioned this pull request May 14, 2016
Closed
bors added a commit that referenced this pull request May 14, 2016
@bors
Auto merge of #33629 - sanxiyn:rollup, r=sanxiyn
a9d15db 
Rollup of 15 pull requests

- Successful merges: #33342, #33393, #33415, #33475, #33517, #33533, #33534, #33565, #33580, #33590, #33591, #33598, #33603, #33604, #33605
- Failed merges: #33578
@eddyb eddyb mentioned this pull request May 14, 2016
Merged
eddyb added a commit to eddyb/rust that referenced this pull request May 15, 2016
@eddyb
Rollup merge of rust-lang#33603 - tshepang:no-need, r=apasel422
752137f 
doc: to_string not needed since we gots coercion
bors added a commit that referenced this pull request May 16, 2016
@bors
Auto merge of #33643 - eddyb:rollup, r=eddyb
bb39c49 
Rollup of 27 pull requests

- Successful merges: #33342, #33393, #33415, #33475, #33517, #33533, #33534, #33565, #33580, #33584, #33585, #33588, #33590, #33591, #33593, #33598, #33600, #33602, #33603, #33604, #33605, #33607, #33612, #33620, #33633, #33634, #33635
- Failed merges: #33578
@bors bors merged commit 226cb9c into rust-lang:master May 16, 2016
@tshepang tshepang deleted the no-need branch May 16, 2016 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tshepang @rust-highfive @apasel422 @bors @ollie27 @aturon