Updated E0081 to new format #35353
Updated E0081 to new format #35353
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| //~^^ NOTE conflicting | ||
| B = 1, //~ ERROR discriminant value | ||
| //~^ NOTE enum already | ||
| //~^^^ NOTE first use |
There was a problem hiding this comment.
Assuming I'm reading this right, the NOTE first use for these errors should be on a label on line 14 A = 1.
Are the spans you're getting showing up on 15, 18, and 20 instead?
|
Looks good! Thanks for updating the tests, too. @bors r+ rollup |
|
📌 Commit 00179a7 has been approved by |
Updated E0081 to new format Part of rust-lang#35233. r? @jonathandturner
Updated E0081 to new format Part of rust-lang#35233. r? @jonathandturner
…rner Shrink span to variant discriminant expression for E0081 Part of rust-lang#35233. Extension of rust-lang#35353. Fixes rust-lang#35224. r? @jonathandturner
…rner Shrink span to variant discriminant expression for E0081 Part of rust-lang#35233. Extension of rust-lang#35353. Fixes rust-lang#35224. r? @jonathandturner
…rner Shrink span to variant discriminant expression for E0081 Part of rust-lang#35233. Extension of rust-lang#35353. Fixes rust-lang#35224. r? @jonathandturner
Part of #35233. r? @jonathandturner