Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated error message E0282 #35366

Merged
merged 1 commit into from
Aug 7, 2016
Merged

Updated error message E0282 #35366

merged 1 commit into from
Aug 7, 2016

Conversation

medzin
Copy link
Contributor

@medzin medzin commented Aug 5, 2016

Fixes #35312 as part of #35233.

r? @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt
Copy link
Contributor

sophiajt commented Aug 5, 2016 •
edited
Loading

Looks good!

One small request. I think I was asleep when I wrote the original issue. Can we change it from: "cannot infer type about _" to "cannot infer type for _"

Sorry about that :)

@sophiajt
Copy link
Contributor

sophiajt commented Aug 5, 2016

Great, thanks for updating it!

@bors r+ rollup

@medzin
Copy link
Contributor Author

medzin commented Aug 5, 2016

@jonathandturner fixed! :)

@bors
Copy link
Contributor

bors commented Aug 5, 2016

📌 Commit ff96b56 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 5, 2016
Rollup merge of rust-lang#35366 - medzin:E0282, r=jonathandturner
2139a0a 
Updated error message E0282

Fixes rust-lang#35312 as part of rust-lang#35233.

r? @GuillaumeGomez
@sophiajt sophiajt mentioned this pull request Aug 5, 2016
Closed
@sophiajt
Copy link
Contributor

sophiajt commented Aug 5, 2016

@bors r-

Looks like I jumped the gun. Just let me know when you're ready.

@medzin
Copy link
Contributor Author

medzin commented Aug 5, 2016

@jonathandturner all tests are green now :)

@sophiajt
Copy link
Contributor

sophiajt commented Aug 5, 2016

Sounds good!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 5, 2016

📌 Commit cb90cce has been approved by jonathandturner

bors added a commit that referenced this pull request Aug 6, 2016
@bors
Auto merge of #35397 - jonathandturner:rollup, r=jonathandturner
43446fc 
Rollup of 18 pull requests

- Successful merges: #34916, #35287, #35288, #35331, #35353, #35356, #35363, #35364, #35366, #35368, #35370, #35372, #35373, #35374, #35375, #35376, #35380, #35394
- Failed merges: #35395
@eddyb eddyb mentioned this pull request Aug 6, 2016
Merged
@GuillaumeGomez
Copy link
Member

@bors: r-

Please squash your last commit.

@medzin
Copy link
Contributor Author

medzin commented Aug 6, 2016

@GuillaumeGomez only last or all to one?

bors added a commit that referenced this pull request Aug 6, 2016
@bors
Auto merge of #35407 - eddyb:rollup, r=eddyb
444ff9f 
Rollup of 21 pull requests

- Successful merges: #33951, #34916, #35287, #35288, #35351, #35353, #35356, #35362, #35363, #35364, #35366, #35368, #35370, #35372, #35373, #35374, #35375, #35376, #35380, #35393, #35394
- Failed merges: #35331, #35395
@GuillaumeGomez
Copy link
Member

All to one please.

@medzin
Copy link
Contributor Author

medzin commented Aug 6, 2016

@GuillaumeGomez done

@sophiajt
Copy link
Contributor

sophiajt commented Aug 6, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Aug 6, 2016

📌 Commit 19e4579 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Rollup merge of rust-lang#35366 - medzin:E0282, r=jonathandturner
4985246 
Updated error message E0282

Fixes rust-lang#35312 as part of rust-lang#35233.

r? @GuillaumeGomez
@sophiajt sophiajt mentioned this pull request Aug 7, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Rollup merge of rust-lang#35366 - medzin:E0282, r=jonathandturner
5b22d2b 
Updated error message E0282

Fixes rust-lang#35312 as part of rust-lang#35233.

r? @GuillaumeGomez
@sophiajt sophiajt mentioned this pull request Aug 7, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Rollup merge of rust-lang#35366 - medzin:E0282, r=jonathandturner
94cb842 
Updated error message E0282

Fixes rust-lang#35312 as part of rust-lang#35233.

r? @GuillaumeGomez
@sophiajt sophiajt mentioned this pull request Aug 7, 2016
Merged
bors added a commit that referenced this pull request Aug 7, 2016
@bors
Auto merge of #35469 - jonathandturner:rollup, r=jonathandturner
1744c46 
Rollup of 21 pull requests

- Successful merges: #35314, #35355, #35357, #35366, #35394, #35410, #35411, #35413, #35417, #35419, #35421, #35429, #35433, #35434, #35436, #35439, #35443, #35454, #35455, #35467, #35468
- Failed merges: #35395, #35415
@bors bors merged commit 19e4579 into rust-lang:master Aug 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@medzin @rust-highfive @sophiajt @bors @GuillaumeGomez