run rustfmt on compiletest folder in src/tools/ folder #35448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
cc @nrc |
|
|
||
| let primary_spans: Vec<_> = spans_in_this_file.iter() | ||
| .cloned() | ||
| .filter(|span| span.is_primary) |
There was a problem hiding this comment.
@nrc how does rustfmt decide when to align to . in a method-call chain? Or does it just never do it?
There was a problem hiding this comment.
It uses block indent atm. This has been something of a tricky point - we used to use visual indent which looked pretty but caused pretty bad rightward drift and caused problems with closures, so now we always use block indent which doesn't look as good, but does work well with others. Hopefully we can improve it further in the future
|
@bors r+ |
|
📌 Commit abe1cc7 has been approved by |
|
@bors rollup |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Aug 10, 2016
…omatsakis run rustfmt on compiletest folder in src/tools/ folder
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 10, 2016
…omatsakis run rustfmt on compiletest folder in src/tools/ folder
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 11, 2016
…omatsakis run rustfmt on compiletest folder in src/tools/ folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.