Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0263 updated to new format. #35557

Merged
merged 1 commit into from
Aug 12, 2016
Merged

E0263 updated to new format. #35557

merged 1 commit into from
Aug 12, 2016

Conversation

Limeth
Copy link

@Limeth Limeth commented Aug 9, 2016

Fixes #35518. Part of #35233.
r? @jonathandturner

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt
Copy link
Contributor

sophiajt commented Aug 9, 2016

Thanks for the PR!

Looks like this is close, but you'll want to use a span_label instead of a span_note here:

                        .span_note(lifetime_i.lifetime.span,
                                   &format!("previous declaration here"))

@Limeth
Copy link
Author

Limeth commented Aug 9, 2016

I changed it to span_label. Since I was using span_label for the ^^^ styled underline, I thought the span_note method would be for the --- underline. Shoud be good now.

@sophiajt
Copy link
Contributor

sophiajt commented Aug 9, 2016

@Limeth - cool, thanks.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 9, 2016

📌 Commit 46265a0 has been approved by jonathandturner

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 10, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 10, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 11, 2016
bors added a commit that referenced this pull request Aug 11, 2016
@bors bors merged commit 46265a0 into rust-lang:master Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants