Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 19 pull requests #35834

Closed
wants to merge 41 commits into from
Closed

Rollup of 19 pull requests #35834

wants to merge 41 commits into from

Commits on Aug 15, 2016

  1. explicitly show how iterating over .. fails

    I've also removed the `main()` wrapper, which I believe is extraneous.
    LMK if that's incorrect.
    matthew-piziak committed Aug 15, 2016
    Configuration menu
    Copy the full SHA
    377ae44 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2016

  1. RangeFull for-loop iteration fails because of IntoIterator

    Saying that "[for-loop iteration] fails because .. has no IntoIterator
    impl" is more direct than saying "...no Iterator impl" because for loops
    sugar into IntoIterator invocations. It just happens that the other
    Range* operators implement Iterator and rely on the fact that
    `IntoIterator` is implemented for `T: Iterator`.
    matthew-piziak committed Aug 16, 2016
    Configuration menu
    Copy the full SHA
    c186da7 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2016

  1. accumulate vector and assert for RangeFrom and RangeInclusive examples

    PR rust-lang#35695 for `Range` was approved, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
    matthew-piziak committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    95c53b1 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2016

  1. replace Add example with something more evocative of addition

    Currently most of the operator traits use trivial implementation
    examples that only perform side effects. Honestly, that might not be too
    bad for the sake of documentation; but anyway, here's a proposal to move
    a slightly modified version of the module-level point-addition example
    into the `Add` documentation, since it's more evocative of addition
    semantics.
    
    Part of rust-lang#29365
    
    wrap identifiers in backticks
    
    minor rephrasing
    
    fix module-level documentation to be more truthful
    
    This branch changes the example for `Add` to no longer be a "minimum implementation that prints something to the screen".
    matthew-piziak committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    dcee93a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0dc13ee View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dae1406 View commit details
    Browse the repository at this point in the history
  4. Fix tiny spelling mistake in book

    Changed datastructure to data structure
    ErikUggeldahl committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    6976991 View commit details
    Browse the repository at this point in the history
  5. Add a few doc examples for std::ffi::OsStr.

    * `std::ffi::OsStr::new`.
    * `std::ffi::OsStr::is_empty`.
    * `std::ffi::OsStr::len`.
    frewsxcv committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    c2b6f72 View commit details
    Browse the repository at this point in the history
  6. Fix minor typo

    cantino committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    06302cb View commit details
    Browse the repository at this point in the history
  7. demonstrate RHS != Self use cases for Mul and Div

    Vector-scalar multipication is a good usecase for this. Thanks #rust!
    matthew-piziak committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    9563f14 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    469b7fd View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    161cb36 View commit details
    Browse the repository at this point in the history
  10. note that calling drop() explicitly is a compiler error

    Part of rust-lang#29365
    
    explain that std::mem::drop in prelude will invoke Drop
    
    change "prelude" -> "the prelude"; change links to reference-style
    
    move link references to links' section
    matthew-piziak committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    a516dbb View commit details
    Browse the repository at this point in the history
  11. replace AddAssign example with something more evocative of addition

    This is analogous to PR rust-lang#35709 for the `Add` trait.
    matthew-piziak committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    6c66eaa View commit details
    Browse the repository at this point in the history
  12. Add workaround to detect correct compiler version

    Jonathan Turner committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    ffbb860 View commit details
    Browse the repository at this point in the history
  13. Update error format for E0232

    mlayne committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    39f318b View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2016

  1. Fix label messages for E0133

    wdv4758h committed Aug 19, 2016
    Configuration menu
    Copy the full SHA
    2128d31 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2c190ad View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f551674 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    06147ac View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c0eccb1 View commit details
    Browse the repository at this point in the history
  6. Update E0428 to new format

    trixnz committed Aug 19, 2016
    Configuration menu
    Copy the full SHA
    3b64cf6 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#35701 - matthew-piziak:rangefull-example-er…

    …ror, r=steveklabnik
    
    explicitly show how iterating over `..` fails
    
    I've also removed the `main()` wrapper, which I believe is extraneous.
    LMK if that's incorrect.
    Jonathan Turner committed Aug 19, 2016
    Configuration menu
    Copy the full SHA
    05fb19c View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#35709 - matthew-piziak:add-trait-example, r…

    …=GuillaumeGomez
    
    replace `Add` example with something more evocative of addition
    
    Currently most of the operator traits use trivial implementation
    examples that only perform side effects. Honestly, that might not be too
    bad for the sake of documentation; but anyway, here's a proposal to move
    a slightly modified version of the module-level point-addition example
    into the `Add` documentation, since it's more evocative of addition
    semantics.
    
    Part of rust-lang#29365
    Jonathan Turner committed Aug 19, 2016
    Configuration menu
    Copy the full SHA
    cf4432a View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#35710 - matthew-piziak:explicit-drop, r=ste…

    …veklabnik
    
    note that calling drop() explicitly is a compiler error
    
    Part of rust-lang#29365
    Jonathan Turner committed Aug 19, 2016
    Configuration menu
    Copy the full SHA
    f60a669 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#35758 - matthew-piziak:vec-assert-over-prin…

    …tln-remaining, r=GuillaumeGomez
    
    accumulate vector and assert for RangeFrom and RangeInclusive examples
    
    PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
    Jonathan Turner committed Aug 19, 2016
    Configuration menu
    Copy the full SHA
    c0c2f33 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#35775 - frewsxcv:os-str-doc-examples, r=Gui…

    …llaumeGomez
    
    Add a few doc examples for `std::ffi::OsStr`.
    Jonathan Turner committed Aug 19, 2016
    Configuration menu
    Copy the full SHA
    6479cf7 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#35778 - clementmiao:E0395_new_error_format,…

    … r=jonathandturner
    
    updated E0395 to new error format
    
    Updated E0395 to new error format.
    Part of rust-lang#35233
    Fixes rust-lang#35693
    
    Thanks again for letting me help!
    
    r? @jonathandturner
    Jonathan Turner committed Aug 19, 2016
    Configuration menu
    Copy the full SHA
    d9e0472 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#35780 - clementmiao:E0396_new_err_format, r…

    …=jonathandturner
    
    updated E0396 to new error format
    
    Updated E0396 to new error format.
    Part of rust-lang#35233
    Fixes rust-lang#35779
    
    Thanks again for letting me help!
    
    r? @jonathandturner
    Jonathan Turner committed Aug 19, 2016
    Configuration menu
    Copy the full SHA
    f412ce0 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#35781 - ErikUggeldahl:spellingfix, r=apasel422

    Very minor spelling fix in the book
    
    Changed datastructure to data structure.
    
    r? @steveklabnik
    Jonathan Turner committed Aug 19, 2016
    Configuration menu
    Copy the full SHA
    e687461 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#35794 - cantino:fix-typo, r=apasel422

    Fix minor typo
    
    Minor typo in the book.
    Jonathan Turner committed Aug 19, 2016
    Configuration menu
    Copy the full SHA
    598ebb8 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#35800 - matthew-piziak:mul-div-examples, r=…

    …steveklabnik
    
    demonstrate `RHS != Self` use cases for `Mul` and `Div`
    
    Vector-scalar multipication is a good usecase for this. Thanks #rust!
    Jonathan Turner committed Aug 19, 2016
    Configuration menu
    Copy the full SHA
    d6ab6ed View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#35804 - pliniker:master, r=jonathandturner

    Update error message for E0084
    
    Fixes rust-lang#35792 as part of rust-lang#35233
    
    r? @jonathandturner
    Jonathan Turner committed Aug 19, 2016
    Configuration menu
    Copy the full SHA
    1136f42 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#35806 - matthew-piziak:addassign-example, r…

    …=steveklabnik
    
    replace `AddAssign` example with something more evocative of addition
    
    This is analogous to PR rust-lang#35709 for the `Add` trait.
    Jonathan Turner committed Aug 19, 2016
    Configuration menu
    Copy the full SHA
    f21dcbe View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#35811 - jonathandturner:fix_rustbuild_versi…

    …on_test, r=alexcrichton
    
    Add workaround to detect correct compiler version
    
    This adds a workaround which fixes a rustbuild issue where the wrong compiler is checked for the version number.  The bug would arise if you build the system correctly then changed to any other version (eg doing a `git pull`).  After changing to the new version, building would fail and complain that crates were built with the wrong compiler.
    
    There are actually two compilers at play, the bootstrapping compiler (called the "snapshot" compiler) and the actual compiler being built (the "real" compiler).  In the case of this issue, the wrong compiler was being checked for version mismatch.
    
    r? @alexcrichton
    Jonathan Turner committed Aug 19, 2016
    Configuration menu
    Copy the full SHA
    c63ed55 View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#35812 - mlayne:E0232, r=jonathandturner

    Update error format for E0232
    
    Fixes rust-lang#35795, as part of rust-lang#35233.
    
    Excited to make my first contribution to rustc!
    
    r? @jonathandturner
    Jonathan Turner committed Aug 19, 2016
    Configuration menu
    Copy the full SHA
    36708fd View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#35818 - wdv4758h:E0133-label, r=Aatch

    Fix label messages for E0133
    
    Issue rust-lang#35789
    Jonathan Turner committed Aug 19, 2016
    Configuration menu
    Copy the full SHA
    570165e View commit details
    Browse the repository at this point in the history
  22. Rollup merge of rust-lang#35824 - GuillaumeGomez:err_codes, r=jonatha…

    …ndturner
    
    Err codes
    
    r? @jonathandturner
    Jonathan Turner committed Aug 19, 2016
    Configuration menu
    Copy the full SHA
    6e184cc View commit details
    Browse the repository at this point in the history
  23. Rollup merge of rust-lang#35827 - matthew-piziak:neg-example, r=steve…

    …klabnik
    
    replace `Not` example with something more evocative
    Jonathan Turner committed Aug 19, 2016
    Configuration menu
    Copy the full SHA
    063e01c View commit details
    Browse the repository at this point in the history
  24. Rollup merge of rust-lang#35830 - matthew-piziak:not-example, r=steve…

    …klabnik
    
    replace `Neg` example with something more evocative of negation
    Jonathan Turner committed Aug 19, 2016
    Configuration menu
    Copy the full SHA
    2afa054 View commit details
    Browse the repository at this point in the history
  25. Rollup merge of rust-lang#35831 - trixnz:error-428, r=jonathandturner

    Update E0428 to new format
    
    Fixes rust-lang#35798 as part of rust-lang#35233.
    
    r? @jonathandturner
    Jonathan Turner committed Aug 19, 2016
    Configuration menu
    Copy the full SHA
    7f75382 View commit details
    Browse the repository at this point in the history