-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 19 pull requests #35834
Rollup of 19 pull requests #35834
Commits on Aug 15, 2016
-
explicitly show how iterating over
..
failsI've also removed the `main()` wrapper, which I believe is extraneous. LMK if that's incorrect.
Configuration menu - View commit details
-
Copy full SHA for 377ae44 - Browse repository at this point
Copy the full SHA 377ae44View commit details
Commits on Aug 16, 2016
-
RangeFull for-loop iteration fails because of IntoIterator
Saying that "[for-loop iteration] fails because .. has no IntoIterator impl" is more direct than saying "...no Iterator impl" because for loops sugar into IntoIterator invocations. It just happens that the other Range* operators implement Iterator and rely on the fact that `IntoIterator` is implemented for `T: Iterator`.
Configuration menu - View commit details
-
Copy full SHA for c186da7 - Browse repository at this point
Copy the full SHA c186da7View commit details
Commits on Aug 17, 2016
-
accumulate vector and assert for RangeFrom and RangeInclusive examples
PR rust-lang#35695 for `Range` was approved, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
Configuration menu - View commit details
-
Copy full SHA for 95c53b1 - Browse repository at this point
Copy the full SHA 95c53b1View commit details
Commits on Aug 18, 2016
-
replace Add example with something more evocative of addition
Currently most of the operator traits use trivial implementation examples that only perform side effects. Honestly, that might not be too bad for the sake of documentation; but anyway, here's a proposal to move a slightly modified version of the module-level point-addition example into the `Add` documentation, since it's more evocative of addition semantics. Part of rust-lang#29365 wrap identifiers in backticks minor rephrasing fix module-level documentation to be more truthful This branch changes the example for `Add` to no longer be a "minimum implementation that prints something to the screen".
Configuration menu - View commit details
-
Copy full SHA for dcee93a - Browse repository at this point
Copy the full SHA dcee93aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0dc13ee - Browse repository at this point
Copy the full SHA 0dc13eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for dae1406 - Browse repository at this point
Copy the full SHA dae1406View commit details -
Fix tiny spelling mistake in book
Changed datastructure to data structure
Configuration menu - View commit details
-
Copy full SHA for 6976991 - Browse repository at this point
Copy the full SHA 6976991View commit details -
Add a few doc examples for
std::ffi::OsStr
.* `std::ffi::OsStr::new`. * `std::ffi::OsStr::is_empty`. * `std::ffi::OsStr::len`.
Configuration menu - View commit details
-
Copy full SHA for c2b6f72 - Browse repository at this point
Copy the full SHA c2b6f72View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06302cb - Browse repository at this point
Copy the full SHA 06302cbView commit details -
demonstrate
RHS != Self
use cases forMul
andDiv
Vector-scalar multipication is a good usecase for this. Thanks #rust!
Configuration menu - View commit details
-
Copy full SHA for 9563f14 - Browse repository at this point
Copy the full SHA 9563f14View commit details -
Configuration menu - View commit details
-
Copy full SHA for 469b7fd - Browse repository at this point
Copy the full SHA 469b7fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 161cb36 - Browse repository at this point
Copy the full SHA 161cb36View commit details -
note that calling drop() explicitly is a compiler error
Part of rust-lang#29365 explain that std::mem::drop in prelude will invoke Drop change "prelude" -> "the prelude"; change links to reference-style move link references to links' section
Configuration menu - View commit details
-
Copy full SHA for a516dbb - Browse repository at this point
Copy the full SHA a516dbbView commit details -
replace
AddAssign
example with something more evocative of additionThis is analogous to PR rust-lang#35709 for the `Add` trait.
Configuration menu - View commit details
-
Copy full SHA for 6c66eaa - Browse repository at this point
Copy the full SHA 6c66eaaView commit details -
Add workaround to detect correct compiler version
Jonathan Turner committedAug 18, 2016 Configuration menu - View commit details
-
Copy full SHA for ffbb860 - Browse repository at this point
Copy the full SHA ffbb860View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39f318b - Browse repository at this point
Copy the full SHA 39f318bView commit details
Commits on Aug 19, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 2128d31 - Browse repository at this point
Copy the full SHA 2128d31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c190ad - Browse repository at this point
Copy the full SHA 2c190adView commit details -
Configuration menu - View commit details
-
Copy full SHA for f551674 - Browse repository at this point
Copy the full SHA f551674View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06147ac - Browse repository at this point
Copy the full SHA 06147acView commit details -
Configuration menu - View commit details
-
Copy full SHA for c0eccb1 - Browse repository at this point
Copy the full SHA c0eccb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b64cf6 - Browse repository at this point
Copy the full SHA 3b64cf6View commit details -
Rollup merge of rust-lang#35701 - matthew-piziak:rangefull-example-er…
…ror, r=steveklabnik explicitly show how iterating over `..` fails I've also removed the `main()` wrapper, which I believe is extraneous. LMK if that's incorrect.
Jonathan Turner committedAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for 05fb19c - Browse repository at this point
Copy the full SHA 05fb19cView commit details -
Rollup merge of rust-lang#35709 - matthew-piziak:add-trait-example, r…
…=GuillaumeGomez replace `Add` example with something more evocative of addition Currently most of the operator traits use trivial implementation examples that only perform side effects. Honestly, that might not be too bad for the sake of documentation; but anyway, here's a proposal to move a slightly modified version of the module-level point-addition example into the `Add` documentation, since it's more evocative of addition semantics. Part of rust-lang#29365
Jonathan Turner committedAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for cf4432a - Browse repository at this point
Copy the full SHA cf4432aView commit details -
Rollup merge of rust-lang#35710 - matthew-piziak:explicit-drop, r=ste…
…veklabnik note that calling drop() explicitly is a compiler error Part of rust-lang#29365
Jonathan Turner committedAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for f60a669 - Browse repository at this point
Copy the full SHA f60a669View commit details -
Rollup merge of rust-lang#35758 - matthew-piziak:vec-assert-over-prin…
…tln-remaining, r=GuillaumeGomez accumulate vector and assert for RangeFrom and RangeInclusive examples PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
Jonathan Turner committedAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for c0c2f33 - Browse repository at this point
Copy the full SHA c0c2f33View commit details -
Rollup merge of rust-lang#35775 - frewsxcv:os-str-doc-examples, r=Gui…
…llaumeGomez Add a few doc examples for `std::ffi::OsStr`.
Jonathan Turner committedAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for 6479cf7 - Browse repository at this point
Copy the full SHA 6479cf7View commit details -
Rollup merge of rust-lang#35778 - clementmiao:E0395_new_error_format,…
… r=jonathandturner updated E0395 to new error format Updated E0395 to new error format. Part of rust-lang#35233 Fixes rust-lang#35693 Thanks again for letting me help! r? @jonathandturner
Jonathan Turner committedAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for d9e0472 - Browse repository at this point
Copy the full SHA d9e0472View commit details -
Rollup merge of rust-lang#35780 - clementmiao:E0396_new_err_format, r…
…=jonathandturner updated E0396 to new error format Updated E0396 to new error format. Part of rust-lang#35233 Fixes rust-lang#35779 Thanks again for letting me help! r? @jonathandturner
Jonathan Turner committedAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for f412ce0 - Browse repository at this point
Copy the full SHA f412ce0View commit details -
Rollup merge of rust-lang#35781 - ErikUggeldahl:spellingfix, r=apasel422
Very minor spelling fix in the book Changed datastructure to data structure. r? @steveklabnik
Jonathan Turner committedAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for e687461 - Browse repository at this point
Copy the full SHA e687461View commit details -
Rollup merge of rust-lang#35794 - cantino:fix-typo, r=apasel422
Fix minor typo Minor typo in the book.
Jonathan Turner committedAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for 598ebb8 - Browse repository at this point
Copy the full SHA 598ebb8View commit details -
Rollup merge of rust-lang#35800 - matthew-piziak:mul-div-examples, r=…
…steveklabnik demonstrate `RHS != Self` use cases for `Mul` and `Div` Vector-scalar multipication is a good usecase for this. Thanks #rust!
Jonathan Turner committedAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for d6ab6ed - Browse repository at this point
Copy the full SHA d6ab6edView commit details -
Rollup merge of rust-lang#35804 - pliniker:master, r=jonathandturner
Update error message for E0084 Fixes rust-lang#35792 as part of rust-lang#35233 r? @jonathandturner
Jonathan Turner committedAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for 1136f42 - Browse repository at this point
Copy the full SHA 1136f42View commit details -
Rollup merge of rust-lang#35806 - matthew-piziak:addassign-example, r…
…=steveklabnik replace `AddAssign` example with something more evocative of addition This is analogous to PR rust-lang#35709 for the `Add` trait.
Jonathan Turner committedAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for f21dcbe - Browse repository at this point
Copy the full SHA f21dcbeView commit details -
Rollup merge of rust-lang#35811 - jonathandturner:fix_rustbuild_versi…
…on_test, r=alexcrichton Add workaround to detect correct compiler version This adds a workaround which fixes a rustbuild issue where the wrong compiler is checked for the version number. The bug would arise if you build the system correctly then changed to any other version (eg doing a `git pull`). After changing to the new version, building would fail and complain that crates were built with the wrong compiler. There are actually two compilers at play, the bootstrapping compiler (called the "snapshot" compiler) and the actual compiler being built (the "real" compiler). In the case of this issue, the wrong compiler was being checked for version mismatch. r? @alexcrichton
Jonathan Turner committedAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for c63ed55 - Browse repository at this point
Copy the full SHA c63ed55View commit details -
Rollup merge of rust-lang#35812 - mlayne:E0232, r=jonathandturner
Update error format for E0232 Fixes rust-lang#35795, as part of rust-lang#35233. Excited to make my first contribution to rustc! r? @jonathandturner
Jonathan Turner committedAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for 36708fd - Browse repository at this point
Copy the full SHA 36708fdView commit details -
Rollup merge of rust-lang#35818 - wdv4758h:E0133-label, r=Aatch
Fix label messages for E0133 Issue rust-lang#35789
Jonathan Turner committedAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for 570165e - Browse repository at this point
Copy the full SHA 570165eView commit details -
Rollup merge of rust-lang#35824 - GuillaumeGomez:err_codes, r=jonatha…
…ndturner Err codes r? @jonathandturner
Jonathan Turner committedAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for 6e184cc - Browse repository at this point
Copy the full SHA 6e184ccView commit details -
Rollup merge of rust-lang#35827 - matthew-piziak:neg-example, r=steve…
…klabnik replace `Not` example with something more evocative
Jonathan Turner committedAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for 063e01c - Browse repository at this point
Copy the full SHA 063e01cView commit details -
Rollup merge of rust-lang#35830 - matthew-piziak:not-example, r=steve…
…klabnik replace `Neg` example with something more evocative of negation
Jonathan Turner committedAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for 2afa054 - Browse repository at this point
Copy the full SHA 2afa054View commit details -
Rollup merge of rust-lang#35831 - trixnz:error-428, r=jonathandturner
Update E0428 to new format Fixes rust-lang#35798 as part of rust-lang#35233. r? @jonathandturner
Jonathan Turner committedAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for 7f75382 - Browse repository at this point
Copy the full SHA 7f75382View commit details